Skip to content

Commit

Permalink
fix: peer dependency is not unlinked
Browse files Browse the repository at this point in the history
close #6271
  • Loading branch information
zkochan committed Mar 24, 2023
1 parent c4ec572 commit 0953965
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .changeset/slow-meals-worry.md
@@ -0,0 +1,6 @@
---
"@pnpm/resolve-dependencies": patch
"pnpm": patch
---

Fix regression introduced in v7.30.1 [#6271](https://github.com/pnpm/pnpm/issues/6271).
7 changes: 1 addition & 6 deletions pkg-manager/resolve-dependencies/src/index.ts
Expand Up @@ -178,12 +178,7 @@ export async function resolveDependencies (
? await getTopParents(
difference(
Object.keys(getAllDependenciesFromManifest(project.manifest)),
[
...resolvedImporter.directDependencies
.filter((_, index) => project.wantedDependencies[index]?.isNew === true)
.map(({ alias }) => alias) || [],
...resolvedImporter.linkedDependencies.map(({ alias }) => alias),
]
resolvedImporter.directDependencies.map(({ alias }) => alias) || [],

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 14.6

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 14.6

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 16

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 16

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 18

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 18

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 19

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 19

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 14.6

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 14.6

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 16

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 16

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 18

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 18

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / ubuntu-latest / Node.js 19

Unexpected trailing comma

Check failure on line 181 in pkg-manager/resolve-dependencies/src/index.ts

View workflow job for this annotation

GitHub Actions / windows-latest / Node.js 19

Unexpected trailing comma
),
project.modulesDir
)
Expand Down

0 comments on commit 0953965

Please sign in to comment.