fix: use proper default value for store-dir, cache-dir on macOS

ref #2574
pnpm · Jul 7, 2021 · 2264bfd · 2264bfd
1 parent 489ee02
commit 2264bfd
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/.changeset/plenty-moose-tie.md b/.changeset/plenty-moose-tie.md
@@ -0,0 +1,5 @@
+---
+"@pnpm/config": patch
+---
+
+Choose proper default state-dir and cache-dir on macOS.
diff --git a/packages/config/src/dirs.ts b/packages/config/src/dirs.ts
@@ -10,6 +10,9 @@ export function getCacheDir (
   if (opts.env.XDG_CACHE_HOME) {
     return path.join(opts.env.XDG_CACHE_HOME, 'pnpm')
   }
+  if (opts.platform === 'darwin') {
+    return path.join(os.homedir(), 'Library/Caches/pnpm')
+  }
   if (opts.platform !== 'win32') {
     return path.join(os.homedir(), '.cache/pnpm')
   }
@@ -28,7 +31,7 @@ export function getStateDir (
   if (opts.env.XDG_STATE_HOME) {
     return path.join(opts.env.XDG_STATE_HOME, 'pnpm')
   }
-  if (opts.platform !== 'win32') {
+  if (opts.platform !== 'win32' && opts.platform !== 'darwin') {
     return path.join(os.homedir(), '.local/state/pnpm')
   }
   if (opts.env.LOCALAPPDATA) {

diff --git a/packages/config/test/dirs.test.ts b/packages/config/test/dirs.test.ts
@@ -13,6 +13,10 @@ test('getCacheDir()', () => {
     env: {},
     platform: 'linux',
   })).toBe(path.join(os.homedir(), '.cache/pnpm'))
+  expect(getCacheDir({
+    env: {},
+    platform: 'darwin',
+  })).toBe(path.join(os.homedir(), 'Library/Caches/pnpm'))
   expect(getCacheDir({
     env: {
       LOCALAPPDATA: '/localappdata',
@@ -36,6 +40,10 @@ test('getStateDir()', () => {
     env: {},
     platform: 'linux',
   })).toBe(path.join(os.homedir(), '.local/state/pnpm'))
+  expect(getStateDir({
+    env: {},
+    platform: 'darwin',
+  })).toBe(path.join(os.homedir(), '.pnpm-state'))
   expect(getStateDir({
     env: {
       LOCALAPPDATA: '/localappdata',