fix(dlx): print install output to stderr (#4696)

close #1698
pnpm · May 7, 2022 · 23a66ba · 23a66ba
1 parent f429d96
commit 23a66ba
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/six-llamas-design.md b/.changeset/six-llamas-design.md
@@ -0,0 +1,5 @@
+---
+"pnpm": patch
+---
+
+`pnpm dlx` should print messages about installation to stderr [#1698](https://github.com/pnpm/pnpm/issues/1698).
diff --git a/packages/pnpm/src/main.ts b/packages/pnpm/src/main.ts
@@ -98,6 +98,9 @@ export default async function run (inputArgv: string[]) {
       workspaceDir,
       checkUnknownSetting: false,
     }) as typeof config
+    if (cmd === 'dlx') {
+      config.useStderr = true
+    }
     config.forceSharedLockfile = typeof config.workspaceDir === 'string' && config.sharedWorkspaceLockfile === true
     config.argv = argv
     config.fallbackCommandUsed = fallbackCommandUsed

diff --git a/packages/pnpm/test/cli.ts b/packages/pnpm/test/cli.ts
@@ -126,7 +126,7 @@ test('pnpx works', () => {
 
   const result = execPnpxSync(['--yes', 'hello-world-js-bin'])
 
-  expect(result.stdout.toString()).toMatch(/Hello world!/)
+  expect(result.stdout.toString()).toEqual('Hello world!\n')
   expect(result.status).toBe(0)
 })