refactor: resolvePeers.ts

pnpm · Apr 19, 2022 · 2550e63 · 2550e63
1 parent 2e0174f
commit 2550e63
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/resolve-dependencies/src/resolveDependencyTree.ts b/packages/resolve-dependencies/src/resolveDependencyTree.ts
@@ -230,7 +230,7 @@ function buildTree (
       childrenNodeIds[child.alias] = child.depPath
       continue
     }
-    if (nodeIdContainsSequence(parentNodeId, parentId, child.depPath)) {
+    if (nodeIdContainsSequence(parentNodeId, parentId, child.depPath) || parentId === child.depPath) {
       continue
     }
     const childNodeId = createNodeId(parentNodeId, child.depPath)

diff --git a/packages/resolve-dependencies/src/resolvePeers.ts b/packages/resolve-dependencies/src/resolvePeers.ts
@@ -197,10 +197,10 @@ function resolvePeersOfNode<T extends PartialResolvedPackage> (
     : {
       ...parentParentPkgs,
       ...toPkgByName(
-        Object.keys(children).map((alias) => ({
+        Object.entries(children).map(([alias, nodeId]) => ({
           alias,
-          node: ctx.dependenciesTree[children[alias]],
-          nodeId: children[alias],
+          node: ctx.dependenciesTree[nodeId],
+          nodeId,
         }))
       ),
     }
@@ -345,9 +345,12 @@ function getPreviouslyResolvedChildren<T extends PartialResolvedPackage> (nodeId
   nodeIdChunks.reduce((accNodeId, part) => {
     accNodeId += `>${part}>${ownId}`
     const parentNode = dependenciesTree[`${accNodeId}>`]
+    if (typeof parentNode.children === 'function') {
+      parentNode.children = parentNode.children()
+    }
     Object.assign(
       allChildren,
-      typeof parentNode.children === 'function' ? parentNode.children() : parentNode.children
+      parentNode.children
     )
     return accNodeId
   }, '')