fix: only the add command should fail if there is no bin directory in…

… PATH

ref #5841

.changeset/spicy-panthers-agree.md

@@ -0,0 +1,7 @@
+---
+"@pnpm/config": patch
+"@pnpm/plugin-commands-installation": patch
+"pnpm": patch
+---
+
+Only the `pnpm add --global <pkg>` command should fail if there is no global pnpm bin directory in the system PATH [#5841](https://github.com/pnpm/pnpm/issues/5841).

config/config/src/index.ts

@@ -316,10 +316,6 @@ export async function getConfig (
     if (pnpmConfig.bin) {
       fs.mkdirSync(pnpmConfig.bin, { recursive: true })
       await checkGlobalBinDir(pnpmConfig.bin, { env, shouldAllowWrite: opts.globalDirShouldAllowWrite })
-    } else {
-      throw new PnpmError('NO_GLOBAL_BIN_DIR', 'Unable to find the global bin directory', {
-        hint: 'Run "pnpm setup" to create it automatically, or set the global-bin-dir setting, or the PNPM_HOME env variable. The global bin directory should be in the PATH.',
-      })
     }
     pnpmConfig.save = true
     pnpmConfig.allowNew = true

pkg-manager/plugin-commands-installation/src/add.ts

@@ -193,6 +193,11 @@ export async function handler (
       'If you don\'t want to see this warning anymore, you may set the ignore-workspace-root-check setting to true.'
     )
   }
+  if (opts.global && !opts.bin) {
+    throw new PnpmError('NO_GLOBAL_BIN_DIR', 'Unable to find the global bin directory', {
+      hint: 'Run "pnpm setup" to create it automatically, or set the global-bin-dir setting, or the PNPM_HOME env variable. The global bin directory should be in the PATH.',
+    })
+  }
 
   const include = {
     dependencies: opts.production !== false,