perf(pkgs-graph): speed up createPkgGraph by using a table for manife…

…st name lookup (#6287)
pnpm · Mar 27, 2023 · 35d98c7 · 35d98c7
1 parent c45a421
commit 35d98c7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/.changeset/purple-stingrays-argue.md b/.changeset/purple-stingrays-argue.md
@@ -0,0 +1,5 @@
+---
+"@pnpm/workspace.pkgs-graph": patch
+---
+
+Speed up createPkgGraph by using a table for manifest name lookup
diff --git a/workspace/pkgs-graph/src/index.ts b/workspace/pkgs-graph/src/index.ts
@@ -36,6 +36,12 @@ export function createPkgGraph<T> (pkgs: Array<Package & T>, opts?: {
   } {
   const pkgMap = createPkgMap(pkgs)
   const pkgMapValues = Object.values(pkgMap)
+  const pkgMapByManifestName: Record<string, Package[] | undefined> = {}
+  for (const pkg of pkgMapValues) {
+    if (pkg.manifest.name) {
+      (pkgMapByManifestName[pkg.manifest.name] ??= []).push(pkg)
+    }
+  }
   const unmatched: Array<{ pkgName: string, range: string }> = []
   const graph = mapValues((pkg) => ({
     dependencies: createNode(pkg),
@@ -76,8 +82,8 @@ export function createPkgGraph<T> (pkgs: Array<Package & T>, opts?: {
 
         if (spec.type !== 'version' && spec.type !== 'range') return ''
 
-        const pkgs = pkgMapValues.filter(pkg => pkg.manifest.name === depName)
-        if (pkgs.length === 0) return ''
+        const pkgs = pkgMapByManifestName[depName]
+        if (!pkgs || pkgs.length === 0) return ''
         const versions = pkgs.filter(({ manifest }) => manifest.version)
           .map(pkg => pkg.manifest.version) as string[]