feat(file-reporter): remove file reporter (#5012)

close #4949
pnpm · Jul 13, 2022 · 572b265 · 572b265
1 parent 8936be7
commit 572b265
Show file tree

Hide file tree

Showing 29 changed files with 254 additions and 523 deletions.
diff --git a/.changeset/rare-walls-smell.md b/.changeset/rare-walls-smell.md
@@ -0,0 +1,5 @@
+---
+"pnpm": patch
+---
+
+Remove file reporter logging. Logged file is not useful [#4949](https://github.com/pnpm/pnpm/issues/4949).
diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md
@@ -18,10 +18,6 @@ assignees: ''
 
 ### Code to reproduce the issue:
 
-<!--
-If there was a fatal error also include a gist of your node_modules/.pnpm-debug.log file.
--->
-
 ### Expected behavior:
 
 ### Actual behavior:

diff --git a/packages/file-reporter/CHANGELOG.md b/packages/file-reporter/CHANGELOG.md
diff --git a/packages/file-reporter/README.md b/packages/file-reporter/README.md
diff --git a/packages/file-reporter/jest.config.js b/packages/file-reporter/jest.config.js
diff --git a/packages/file-reporter/package.json b/packages/file-reporter/package.json
diff --git a/packages/file-reporter/src/index.ts b/packages/file-reporter/src/index.ts
diff --git a/packages/file-reporter/test/fixture/1/.gitignore b/packages/file-reporter/test/fixture/1/.gitignore
diff --git a/packages/file-reporter/test/fixture/1/index.js b/packages/file-reporter/test/fixture/1/index.js
diff --git a/packages/file-reporter/test/fixture/1/node_modules/.gitkeep b/packages/file-reporter/test/fixture/1/node_modules/.gitkeep
diff --git a/packages/file-reporter/test/fixture/1/stdin b/packages/file-reporter/test/fixture/1/stdin
diff --git a/packages/file-reporter/test/fixture/1/stdout b/packages/file-reporter/test/fixture/1/stdout
diff --git a/packages/file-reporter/test/fixture/2/index.js b/packages/file-reporter/test/fixture/2/index.js
diff --git a/packages/file-reporter/test/fixture/2/stdin b/packages/file-reporter/test/fixture/2/stdin
diff --git a/packages/file-reporter/test/fixture/3/.gitignore b/packages/file-reporter/test/fixture/3/.gitignore
diff --git a/packages/file-reporter/test/fixture/3/index.js b/packages/file-reporter/test/fixture/3/index.js
diff --git a/packages/file-reporter/test/fixture/3/node_modules/.gitkeep b/packages/file-reporter/test/fixture/3/node_modules/.gitkeep
diff --git a/packages/file-reporter/test/fixture/3/stdin b/packages/file-reporter/test/fixture/3/stdin
diff --git a/packages/file-reporter/test/index.ts b/packages/file-reporter/test/index.ts
diff --git a/packages/file-reporter/tsconfig.json b/packages/file-reporter/tsconfig.json
diff --git a/packages/file-reporter/tsconfig.lint.json b/packages/file-reporter/tsconfig.lint.json
diff --git a/packages/pnpm/package.json b/packages/pnpm/package.json
@@ -30,7 +30,6 @@
     "@pnpm/constants": "workspace:*",
     "@pnpm/core-loggers": "workspace:*",
     "@pnpm/default-reporter": "workspace:*",
-    "@pnpm/file-reporter": "workspace:*",
     "@pnpm/filter-workspace-packages": "workspace:*",
     "@pnpm/find-workspace-dir": "workspace:*",
     "@pnpm/find-workspace-packages": "workspace:*",

diff --git a/packages/pnpm/src/logging/fileLogger.ts b/packages/pnpm/src/logging/fileLogger.ts
diff --git a/packages/pnpm/src/main.ts b/packages/pnpm/src/main.ts
@@ -16,7 +16,6 @@ import chalk from 'chalk'
 import checkForUpdates from './checkForUpdates'
 import pnpmCmds, { rcOptionsTypes } from './cmd'
 import { formatUnknownOptionsError } from './formatError'
-import './logging/fileLogger'
 import parseCliArgs from './parseCliArgs'
 import initReporter, { ReporterType } from './reporter'
 import isCI from 'is-ci'

diff --git a/packages/pnpm/test/cli.ts b/packages/pnpm/test/cli.ts
@@ -1,6 +1,5 @@
 import { createReadStream, promises as fs } from 'fs'
 import path from 'path'
-import pathExists from 'path-exists'
 import prepare, { prepareEmpty } from '@pnpm/prepare'
 import rimraf from '@zkochan/rimraf'
 import execa from 'execa'
@@ -145,7 +144,6 @@ test('exit code from plugin is used to end the process', () => {
 
   expect(result.status).toBe(1)
   expect(result.stdout.toString()).toMatch(/is-positive/)
-  expect(pathExists.sync('node_modules/.pnpm-debug.log')).toBeFalsy()
 })
 
 const PNPM_CLI = path.join(__dirname, '../dist/pnpm.cjs')

diff --git a/packages/pnpm/test/install/misc.ts b/packages/pnpm/test/install/misc.ts
@@ -36,16 +36,6 @@ test('bin files are found by lifecycle scripts', () => {
   expect(result.stdout.toString()).toContain('Hello world!')
 })
 
-skipOnWindows('create a "node_modules/.pnpm-debug.log" file when the command fails', async () => {
-  prepare()
-
-  const result = execPnpmSync(['add', '@zkochan/i-do-not-exist'])
-
-  expect(result.status).toBe(1)
-
-  expect(await exists('.pnpm-debug.log')).toBeTruthy()
-})
-
 skipOnWindows('install --lockfile-only', async () => {
   const project = prepare()
 

diff --git a/packages/pnpm/tsconfig.json b/packages/pnpm/tsconfig.json
@@ -45,9 +45,6 @@
     {
       "path": "../default-reporter"
     },
-    {
-      "path": "../file-reporter"
-    },
     {
       "path": "../filter-workspace-packages"
     },