fix: dir path repeated join in link global (#5434)

pnpm · Oct 1, 2022 · 5beb4e2 · 5beb4e2
1 parent 2e830c0
commit 5beb4e2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/rotten-moose-search.md b/.changeset/rotten-moose-search.md
@@ -0,0 +1,5 @@
+---
+"@pnpm/plugin-commands-installation": patch
+---
+
+fix dir path repeated join in link global
diff --git a/packages/plugin-commands-installation/src/link.ts b/packages/plugin-commands-installation/src/link.ts
@@ -116,7 +116,7 @@ export async function handler (
     const { manifest, writeProjectManifest } = await tryReadProjectManifest(opts.dir, opts)
     const newManifest = await addDependenciesToPackage(
       manifest ?? {},
-      [`link:${opts.cliOptions?.dir ? path.join(cwd, opts.cliOptions.dir) : cwd}`],
+      [`link:${opts.cliOptions?.dir ? path.resolve(opts.cliOptions.dir) : cwd}`],
       linkOpts
     )
     await writeProjectManifest(newManifest)

diff --git a/packages/plugin-commands-installation/test/link.ts b/packages/plugin-commands-installation/test/link.ts
@@ -88,7 +88,7 @@ test('link --dir global bin', async function () {
   await link.handler({
     ...DEFAULT_OPTS,
     cliOptions: {
-      dir: './dir/package-with-bin-in-dir',
+      dir: path.resolve('./dir/package-with-bin-in-dir'),
     },
     bin: globalBin,
     dir: globalDir,