fix: handle undefined version spec (#4487)

pnpm · Mar 28, 2022 · 618842b · 618842b
1 parent cfe345b
commit 618842b
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 2 deletions.
diff --git a/.changeset/wet-rabbits-talk.md b/.changeset/wet-rabbits-talk.md
@@ -0,0 +1,5 @@
+---
+"@pnpm/manifest-utils": patch
+---
+
+Handle undefined version spec.
diff --git a/packages/manifest-utils/src/getPref.ts b/packages/manifest-utils/src/getPref.ts
@@ -7,7 +7,7 @@ export const getPrefix = (alias: string, name: string) => alias !== name ? `npm:
 export function getPref (
   alias: string,
   name: string,
-  version: string,
+  version: string | undefined,
   opts: {
     pinnedVersion?: PinnedVersion
   }
@@ -16,7 +16,8 @@ export function getPref (
   return `${prefix}${createVersionSpec(version, opts.pinnedVersion)}`
 }
 
-export function createVersionSpec (version: string, pinnedVersion?: PinnedVersion) {
+export function createVersionSpec (version: string | undefined, pinnedVersion?: PinnedVersion) {
+  if (!version) return '*'
   switch (pinnedVersion ?? 'major') {
   case 'none':
     return '*'

diff --git a/packages/manifest-utils/test/getPref.test.ts b/packages/manifest-utils/test/getPref.test.ts
@@ -0,0 +1,35 @@
+import { getPref } from '@pnpm/manifest-utils'
+
+test('getPref()', () => {
+  expect(getPref('foo', 'foo', '1.0.0', {})).toEqual('^1.0.0')
+
+  expect(
+    getPref('foo', 'foo', '1.0.0', {
+      pinnedVersion: 'major',
+    })
+  ).toEqual('^1.0.0')
+
+  expect(
+    getPref('foo', 'foo', '2.0.0', {
+      pinnedVersion: 'minor',
+    })
+  ).toEqual('~2.0.0')
+
+  expect(
+    getPref('foo', 'foo', '3.0.0', {
+      pinnedVersion: 'patch',
+    })
+  ).toEqual('3.0.0')
+
+  expect(
+    getPref('foo', 'foo', '4.0.0', {
+      pinnedVersion: 'none',
+    })
+  ).toEqual('*')
+
+  expect(
+    getPref('foo', 'foo', undefined, {
+      pinnedVersion: 'major',
+    })
+  ).toEqual('*')
+})