Skip to content

Commit

Permalink
fix: override peerDependencies in pnpm.overrides (#6955)
Browse files Browse the repository at this point in the history
сlose #6759
  • Loading branch information
nachoaldamav committed Aug 17, 2023
1 parent bf21c9b commit 64bf3c8
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changeset/hungry-sheep-approve.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@pnpm/hooks.read-package-hook": patch
"pnpm": patch
---

Override peerDependencies in `pnpm.overrides` [#6759](https://github.com/pnpm/pnpm/issues/6759).
1 change: 1 addition & 0 deletions hooks/read-package-hook/src/createVersionsOverrider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ function overrideDepsOfPkg (
if (manifest.dependencies != null) overrideDeps(versionOverrides, genericVersionOverrides, manifest.dependencies, dir)
if (manifest.optionalDependencies != null) overrideDeps(versionOverrides, genericVersionOverrides, manifest.optionalDependencies, dir)
if (manifest.devDependencies != null) overrideDeps(versionOverrides, genericVersionOverrides, manifest.devDependencies, dir)
if (manifest.peerDependencies != null) overrideDeps(versionOverrides, genericVersionOverrides, manifest.peerDependencies, dir)
}

function overrideDeps (
Expand Down
23 changes: 22 additions & 1 deletion hooks/read-package-hook/test/createVersionOverrider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -382,4 +382,25 @@ test('createVersionsOverrider() matches intersections', () => {
).toStrictEqual({
dependencies: { foo: '>=1.2.4' },
})
})
})

test('createVersionsOverrider() overrides peerDependencies of another dependency', () => {
const overrider = createVersionsOverrider({
'react-dom>react': '18.1.0',
}, process.cwd())
expect(
overrider({
name: 'react-dom',
version: '18.2.0',
peerDependencies: {
react: '18.2.0',
},
})
).toStrictEqual({
name: 'react-dom',
version: '18.2.0',
peerDependencies: {
react: '18.1.0',
},
})
})

0 comments on commit 64bf3c8

Please sign in to comment.