Skip to content

Commit

Permalink
refactor: outdated
Browse files Browse the repository at this point in the history
  • Loading branch information
zkochan committed Nov 6, 2022
1 parent a755115 commit 72b4d27
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 16 deletions.
10 changes: 6 additions & 4 deletions packages/plugin-commands-outdated/src/outdated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,9 @@ ${renderCurrent(outdatedPkg)} ${chalk.grey('=>')} ${renderLatest(outdatedPkg)}`
}

export interface OutdatedPackageJSONOutput {
currentVersion?: string
latestVersion?: string
current?: string
latest?: string
wanted: string
isDeprecated: boolean
dependencyType: DependenciesField
latestManifest?: PackageManifest
Expand All @@ -278,8 +279,9 @@ function renderOutdatedJSON (outdatedPackages: readonly OutdatedPackage[], opts:
const outdatedPackagesJSON: Record<string, OutdatedPackageJSONOutput> = sortOutdatedPackages(outdatedPackages)
.reduce((acc, outdatedPkg) => {
acc[outdatedPkg.packageName] = {
currentVersion: outdatedPkg.current,
latestVersion: outdatedPkg.latestManifest?.version,
current: outdatedPkg.current,
latest: outdatedPkg.latestManifest?.version,
wanted: outdatedPkg.wanted,
isDeprecated: Boolean(outdatedPkg.latestManifest?.deprecated),
dependencyType: outdatedPkg.belongsTo,
}
Expand Down
5 changes: 3 additions & 2 deletions packages/plugin-commands-outdated/src/recursive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,9 @@ function renderOutdatedJSON (
const outdatedPackagesJSON: Record<string, OutdatedPackageInWorkspaceJSONOutput> = sortOutdatedPackages(Object.values(outdatedMap))
.reduce((acc, outdatedPkg) => {
acc[outdatedPkg.packageName] = {
currentVersion: outdatedPkg.current,
latestVersion: outdatedPkg.latestManifest?.version,
current: outdatedPkg.current,
latest: outdatedPkg.latestManifest?.version,
wanted: outdatedPkg.wanted,
isDeprecated: Boolean(outdatedPkg.latestManifest?.deprecated),
dependencyType: outdatedPkg.belongsTo,
dependentPackages: outdatedPkg.dependentPkgs.map(({ manifest, location }) => ({ name: manifest.name, location })),
Expand Down
15 changes: 9 additions & 6 deletions packages/plugin-commands-outdated/test/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,20 +208,23 @@ test('pnpm outdated: format json', async () => {
expect(exitCode).toBe(1)
expect(stripAnsi(output)).toBe(JSON.stringify({
'@pnpm.e2e/deprecated': {
currentVersion: '1.0.0',
latestVersion: '1.0.0',
current: '1.0.0',
latest: '1.0.0',
wanted: '1.0.0',
isDeprecated: true,
dependencyType: 'dependencies',
},
'is-negative': {
currentVersion: '1.0.0',
latestVersion: '2.1.0',
current: '1.0.0',
latest: '2.1.0',
wanted: '1.0.0',
isDeprecated: false,
dependencyType: 'dependencies',
},
'is-positive': {
currentVersion: '1.0.0',
latestVersion: '3.1.0',
current: '1.0.0',
latest: '3.1.0',
wanted: '1.0.0',
isDeprecated: false,
dependencyType: 'devDependencies',
},
Expand Down
10 changes: 6 additions & 4 deletions packages/plugin-commands-outdated/test/recursive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,9 @@ Dependent: project-2
expect(exitCode).toBe(1)
expect(stripAnsi(output as unknown as string)).toBe(JSON.stringify({
'is-negative': {
currentVersion: '1.0.0',
latestVersion: '2.1.0',
current: '1.0.0',
latest: '2.1.0',
wanted: '1.0.0',
isDeprecated: false,
dependencyType: 'devDependencies',
dependentPackages: [
Expand All @@ -174,8 +175,9 @@ Dependent: project-2
],
},
'is-positive': {
currentVersion: '2.0.0',
latestVersion: '3.1.0',
current: '2.0.0',
latest: '3.1.0',
wanted: '2.0.0',
isDeprecated: false,
dependencyType: 'dependencies',
dependentPackages: [
Expand Down

0 comments on commit 72b4d27

Please sign in to comment.