fix(pnpmfile): remove a dependencies field (#7704)

pnpm · Feb 23, 2024 · 7edb917 · 7edb917
1 parent 086b69c
commit 7edb917
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/quick-toes-tap.md b/.changeset/quick-toes-tap.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/resolve-dependencies": patch
+"pnpm": patch
+---
+
+Deleting a dependencies field via a `readPackage` hook should work [#7704](https://github.com/pnpm/pnpm/pull/7704).
diff --git a/pkg-manager/resolve-dependencies/src/resolveDependencies.ts b/pkg-manager/resolve-dependencies/src/resolveDependencies.ts
@@ -60,6 +60,8 @@ import safePromiseDefer, { type SafePromiseDefer } from 'safe-promise-defer'
 
 const dependencyResolvedLogger = logger('_dependency_resolved')
 
+const omitDepsFields = omit(['dependencies', 'optionalDependencies', 'peerDependencies', 'peerDependenciesMeta'])
+
 export function nodeIdToParents (
   nodeId: string,
   resolvedPackagesByDepPath: ResolvedPackagesByDepPath
@@ -1252,7 +1254,7 @@ async function resolveDependency (
     hasBin = currentPkg.dependencyLockfile.hasBin === true
     pkg = {
       ...nameVerFromPkgSnapshot(currentPkg.depPath, currentPkg.dependencyLockfile),
-      ...currentPkg.dependencyLockfile,
+      ...omitDepsFields(currentPkg.dependencyLockfile),
       ...pkg,
     }
   } else {

diff --git a/pnpm/test/hooks.ts b/pnpm/test/hooks.ts
@@ -242,7 +242,7 @@ test('adding or changing pnpmfile should change pnpmfileChecksum and module stru
   const pnpmfile1 = `
     function readPackage (pkg) {
       if (pkg.optionalDependencies) {
-        pkg.optionalDependencies = {} // 'delete pkg.optionalDependencies' doesn't work here
+        delete pkg.optionalDependencies
       }
       return pkg
     }