fix: don't run prepublishOnly and prepublish on pack

close #2941
pnpm · Jan 20, 2023 · 83fad33 · 83fad33
1 parent 5bede17
commit 83fad33
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/.changeset/thin-keys-march.md b/.changeset/thin-keys-march.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/plugin-commands-publishing": major
+"pnpm": major
+---
+
+`prepublishOnly` and `prepublish` should not be executed on `pnpm pack` [#2941](https://github.com/pnpm/pnpm/issues/2941).
diff --git a/releasing/plugin-commands-publishing/src/pack.ts b/releasing/plugin-commands-publishing/src/pack.ts
@@ -77,10 +77,8 @@ export async function handler (
   })
   if (!opts.ignoreScripts) {
     await _runScriptsIfPresent([
-      'prepublish',
-      'prepare',
-      'prepublishOnly',
       'prepack',
+      'prepare',
     ], entryManifest)
   }
   const dir = entryManifest.publishConfig?.directory

diff --git a/releasing/plugin-commands-publishing/src/publish.ts b/releasing/plugin-commands-publishing/src/publish.ts
@@ -198,6 +198,12 @@ Do you want to continue?`,
       args.splice(index, 2)
     }
   }
+  if (!opts.ignoreScripts) {
+    await _runScriptsIfPresent([
+      'prepublishOnly',
+      'prepublish',
+    ], manifest)
+  }
 
   // We have to publish the tarball from another location.
   // Otherwise, npm would publish the package with the package.json file

diff --git a/releasing/plugin-commands-publishing/test/publish.ts b/releasing/plugin-commands-publishing/test/publish.ts
@@ -645,10 +645,10 @@ test('publish: runs all the lifecycle scripts', async () => {
 
   const { default: outputs } = await import(path.resolve('output.json'))
   expect(outputs).toStrictEqual([
-    'prepublish',
-    'prepare',
     'prepublishOnly',
+    'prepublish',
     'prepack',
+    'prepare',
     'publish',
     'postpublish',
   ])