fix: correctly detect the active Node.js version

ref #4203

.changeset/thick-phones-sing.md

@@ -0,0 +1,5 @@
+---
+"@pnpm/config": patch
+---
+
+Do not return a default value for the node-version setting.

.changeset/thin-chefs-sing.md

@@ -0,0 +1,5 @@
+---
+"pnpm": patch
+---
+
+Correctly detect the active Node.js version, when the pnpm CLI is bundled to an executable [#4203](https://github.com/pnpm/pnpm/issues/4203).

packages/config/package.json

@@ -32,12 +32,12 @@
   },
   "homepage": "https://github.com/pnpm/pnpm/blob/main/packages/config#readme",
   "dependencies": {
+    "@pnpm/npm-conf": "1.0.1",
     "@pnpm/constants": "workspace:6.1.0",
     "@pnpm/error": "workspace:3.0.1",
     "@pnpm/pnpmfile": "workspace:2.0.2",
     "@pnpm/read-project-manifest": "workspace:3.0.2",
     "@pnpm/types": "workspace:8.0.1",
-    "@zkochan/npm-conf": "2.0.2",
     "camelcase": "^6.2.0",
     "can-write-to-dir": "^1.1.1",
     "is-subdir": "^1.1.1",

packages/config/src/index.ts

@@ -2,11 +2,11 @@ import path from 'path'
 import fs from 'fs'
 import { LAYOUT_VERSION } from '@pnpm/constants'
 import PnpmError from '@pnpm/error'
+import loadNpmConf from '@pnpm/npm-conf'
+import npmTypes from '@pnpm/npm-conf/lib/types'
 import { requireHooks } from '@pnpm/pnpmfile'
 import { safeReadProjectManifestOnly } from '@pnpm/read-project-manifest'
 import camelcase from 'camelcase'
-import loadNpmConf from '@zkochan/npm-conf'
-import npmTypes from '@zkochan/npm-conf/lib/types'
 import normalizeRegistryUrl from 'normalize-registry-url'
 import fromPairs from 'ramda/src/fromPairs'
 import realpathMissing from 'realpath-missing'

packages/config/test/globalBinDir.test.ts

@@ -10,8 +10,8 @@ import getConfig from '@pnpm/config'
 const globalBinDir = path.join(homedir(), '.local', 'pnpm')
 const isWindows = process.platform === 'win32'
 
-jest.mock('@zkochan/npm-conf/lib/conf', () => {
-  const originalModule = jest.requireActual('@zkochan/npm-conf/lib/conf')
+jest.mock('@pnpm/npm-conf/lib/conf', () => {
+  const originalModule = jest.requireActual('@pnpm/npm-conf/lib/conf')
   class MockedConf extends originalModule {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     constructor (base: any, types: any) {

packages/config/test/index.ts

@@ -4,8 +4,8 @@ import path from 'path'
 import PATH from 'path-name'
 import getConfig from '@pnpm/config'
 import PnpmError from '@pnpm/error'
+import loadNpmConf from '@pnpm/npm-conf'
 import prepare, { prepareEmpty } from '@pnpm/prepare'
-import loadNpmConf from '@zkochan/npm-conf'
 
 import symlinkDir from 'symlink-dir'
 
@@ -36,6 +36,9 @@ test('getConfig()', async () => {
   expect(config.fetchRetryFactor).toEqual(10)
   expect(config.fetchRetryMintimeout).toEqual(10000)
   expect(config.fetchRetryMaxtimeout).toEqual(60000)
+  // nodeVersion should not have a default value.
+  // When not specified, the package-is-installable package detects nodeVersion automatically.
+  expect(config.nodeVersion).toBeUndefined()
 })
 
 test('throw error if --link-workspace-packages is used with --global', async () => {

typings/local.d.ts

@@ -23,12 +23,12 @@ declare module '@zkochan/libnpx/index' {
   export = anything;
 }
 
-declare module '@zkochan/npm-conf' {
+declare module '@pnpm/npm-conf' {
   const anything: any;
   export = anything;
 }
 
-declare module '@zkochan/npm-conf/lib/types' {
+declare module '@pnpm/npm-conf/lib/types' {
   const anything: any;
   export = anything;
 }