fix: error that sometimes happen on projects with linked deps

close #5327 close #5614
pnpm · Nov 13, 2022 · bf918d1 · bf918d1
1 parent 9ad96e2
commit bf918d1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/mighty-waves-tan.md b/.changeset/mighty-waves-tan.md
@@ -0,0 +1,5 @@
+---
+"pnpm": patch
+---
+
+Fix an error that sometimes happen on projects with linked local dependencies [#5327](https://github.com/pnpm/pnpm/issues/5327).
diff --git a/.changeset/poor-berries-yell.md b/.changeset/poor-berries-yell.md
@@ -0,0 +1,5 @@
+---
+"@pnpm/resolve-dependencies": patch
+---
+
+Fix the nodeId in dependenciesTree for linked local packages.
diff --git a/packages/resolve-dependencies/src/resolveDependencies.ts b/packages/resolve-dependencies/src/resolveDependencies.ts
@@ -665,7 +665,7 @@ async function resolveDependenciesOfDependency (
 
   if (resolveDependencyResult == null) return { resolveDependencyResult: null }
   if (resolveDependencyResult.isLinkedDependency) {
-    ctx.dependenciesTree[resolveDependencyResult.pkgId] = {
+    ctx.dependenciesTree[`link:${path.relative(ctx.lockfileDir, resolveDependencyResult.resolution.directory)}`] = {
       children: {},
       depth: -1,
       installable: true,