fix(resolve-dependencies): prefer versions found in parent packages o…

…nly (#6742) close #6737
pnpm · Jun 30, 2023 · c06f312 · c06f312
1 parent 5a710e5
commit c06f312
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/rare-items-search.md b/.changeset/rare-items-search.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/resolve-dependencies": patch
+"pnpm": patch
+---
+
+Prefer versions found in parent package dependencies only [#6737](https://github.com/pnpm/pnpm/issues/6737).
diff --git a/pkg-manager/resolve-dependencies/src/resolveDependencies.ts b/pkg-manager/resolve-dependencies/src/resolveDependencies.ts
@@ -532,8 +532,8 @@ export async function resolveDependencies (
     }
     const resolvedPackage = ctx.resolvedPackagesByDepPath[pkgAddress.depPath]
     if (!resolvedPackage) continue // This will happen only with linked dependencies
-    if (!newPreferredVersions[resolvedPackage.name]) {
-      newPreferredVersions[resolvedPackage.name] = {}
+    if (!Object.prototype.hasOwnProperty.call(newPreferredVersions, resolvedPackage.name)) {
+      newPreferredVersions[resolvedPackage.name] = { ...preferredVersions[resolvedPackage.name] }
     }
     if (!newPreferredVersions[resolvedPackage.name][resolvedPackage.version]) {
       newPreferredVersions[resolvedPackage.name][resolvedPackage.version] = 'version'