Skip to content

Commit

Permalink
feat(env): show state on fetching node (#5241)
Browse files Browse the repository at this point in the history
* feat(env): show state on fetching node

* fix: use internal logger instead of console.log

* chore: add changeset
  • Loading branch information
JacobLinCool committed Aug 22, 2022
1 parent 1c7b439 commit c242672
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/purple-tools-leave.md
@@ -0,0 +1,5 @@
---
"@pnpm/plugin-commands-env": minor
---

Add an immediate response when fetching Node.js on version switching, preventing pnpm looks like just hanging there.
1 change: 1 addition & 0 deletions packages/plugin-commands-env/package.json
Expand Up @@ -34,6 +34,7 @@
"@pnpm/config": "workspace:*",
"@pnpm/error": "workspace:*",
"@pnpm/fetch": "workspace:*",
"@pnpm/logger": "^4.0.0",
"@pnpm/node.fetcher": "workspace:*",
"@pnpm/node.resolver": "workspace:*",
"@pnpm/store-path": "workspace:*",
Expand Down
2 changes: 2 additions & 0 deletions packages/plugin-commands-env/src/node.ts
Expand Up @@ -2,6 +2,7 @@ import fs from 'fs'
import path from 'path'
import { Config } from '@pnpm/config'
import { createFetchFromRegistry, FetchFromRegistry } from '@pnpm/fetch'
import { globalInfo } from '@pnpm/logger'
import { fetchNode } from '@pnpm/node.fetcher'
import storePath from '@pnpm/store-path'
import loadJsonFile from 'load-json-file'
Expand Down Expand Up @@ -71,6 +72,7 @@ export async function getNodeDir (fetch: FetchFromRegistry, opts: NvmNodeCommand
pnpmHomeDir: opts.pnpmHomeDir,
})
const cafsDir = path.join(storeDir, 'files')
globalInfo(`Fetching Node.js ${opts.useNodeVersion} ...`)
await fetchNode(fetch, opts.useNodeVersion, versionDir, {
...opts,
cafsDir,
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c242672

Please sign in to comment.