feat: update version when pinnedVersion is * (#5720)

close #5681
pnpm · Nov 30, 2022 · c245edf · c245edf
1 parent 93558ce
commit c245edf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/hot-dingos-act.md b/.changeset/hot-dingos-act.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/manifest-utils": patch
+"pnpm": patch
+---
+
+Dependencies specified via `*` should be updated to semver ranges by `pnpm update` [#5681](https://github.com/pnpm/pnpm/issues/5681).
diff --git a/pkg-manifest/manifest-utils/src/getPref.ts b/pkg-manifest/manifest-utils/src/getPref.ts
@@ -19,7 +19,6 @@ export function getPref (
 export function createVersionSpec (version: string | undefined, opts: { pinnedVersion?: PinnedVersion, rolling?: boolean }) {
   switch (opts.pinnedVersion ?? 'major') {
   case 'none':
-    return '*'
   case 'major':
     if (opts.rolling) return '^'
     return !version ? '*' : `^${version}`

diff --git a/pkg-manifest/manifest-utils/test/getPref.test.ts b/pkg-manifest/manifest-utils/test/getPref.test.ts
@@ -25,7 +25,7 @@ test('getPref()', () => {
     getPref('foo', 'foo', '4.0.0', {
       pinnedVersion: 'none',
     })
-  ).toEqual('*')
+  ).toEqual('^4.0.0')
 
   expect(
     getPref('foo', 'foo', undefined, {