fix: issues with storybook and the new lockfile format

close #5976

.changeset/strong-poets-juggle.md

@@ -0,0 +1,6 @@
+---
+"@pnpm/dependency-path": patch
+"pnpm": patch
+---
+
+Directories inside the virtual store should not contain the ( or ) chars. This is to fix issues with storybook and the new v6 `pnpm-lock.yaml` lockfile format [#5976](https://github.com/pnpm/pnpm/issues/5976).

packages/dependency-path/src/index.ts

@@ -143,7 +143,11 @@ export function parse (dependencyPath: string) {
 }
 
 export function depPathToFilename (depPath: string) {
-  const filename = depPathToFilenameUnescaped(depPath).replace(/[\\/:*?"<>|]/g, '+')
+  const filename = depPathToFilenameUnescaped(depPath)
+    .replace(/[\\/:*?"<>|]/g, '+')
+    .replace(/\)\(/g, '_')
+    .replace(/\(/, '_')
+    .replace(/\)$/, '')
   if (filename.length > 120 || filename !== filename.toLowerCase() && !filename.startsWith('file+')) {
     return `${filename.substring(0, 50)}_${createBase32Hash(filename)}`
   }

packages/dependency-path/test/index.ts

@@ -154,6 +154,7 @@ test('depPathToFilename()', () => {
   expect(depPathToFilename('/@foo/bar/1.0.0')).toBe('@foo+bar@1.0.0')
   expect(depPathToFilename('github.com/something/foo/0000?v=1')).toBe('github.com+something+foo@0000+v=1')
   expect(depPathToFilename('\\//:*?"<>|')).toBe('++@+++++++')
+  expect(depPathToFilename('/foo/1.0.0(react@16.0.0)(react-dom@16.0.0)')).toBe('foo@1.0.0_react@16.0.0_react-dom@16.0.0')
 
   const filename = depPathToFilename('file:test/foo-1.0.0.tgz_foo@2.0.0')
   expect(filename).toBe('file+test+foo-1.0.0.tgz_foo@2.0.0')