fix: report correct errors when using the pnpm server (#7032)

pnpm · Sep 2, 2023 · cc785f7 · cc785f7
1 parent d1bd587
commit cc785f7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/wet-lies-smoke.md b/.changeset/wet-lies-smoke.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/default-reporter": patch
+pnpm: patch
+---
+
+Fix a bug causing errors to be printed as `Cannot read properties of undefined (reading 'code')` instead of the underlying reason when using the pnpm store server.
diff --git a/cli/default-reporter/src/reportError.ts b/cli/default-reporter/src/reportError.ts
@@ -21,7 +21,7 @@ const colorPath = chalk.gray
 
 export function reportError (logObj: Log, config?: Config) {
   const errorInfo = getErrorInfo(logObj, config)
-  let output = formatErrorSummary(errorInfo.title, logObj['err']['code'])
+  let output = formatErrorSummary(errorInfo.title, (logObj as LogObjWithPossibleError).err?.code)
   if (logObj['pkgsStack'] != null) {
     if (logObj['pkgsStack'].length > 0) {
       output += `\n\n${formatPkgsStack(logObj['pkgsStack'])}`
@@ -33,6 +33,14 @@ export function reportError (logObj: Log, config?: Config) {
     output += `\n\n${errorInfo.body}`
   }
   return output
+
+  /**
+   * A type to assist with introspection of the logObj.
+   * These objects may or may not have an `err` field.
+   */
+  interface LogObjWithPossibleError {
+    readonly err?: { code?: string }
+  }
 }
 
 function getErrorInfo (logObj: Log, config?: Config): {