do not throw MISSING_HOISTED_LOCATIONS for optional packages

pnpm · May 16, 2023 · d5a58c2 · d5a58c2
1 parent cdb2a93
commit d5a58c2
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/exec/plugin-commands-rebuild/src/implementation/index.ts b/exec/plugin-commands-rebuild/src/implementation/index.ts
@@ -281,9 +281,13 @@ async function _rebuild (
         ? (ctx.modulesFile?.hoistedLocations?.[depPath] ?? []).map((hoistedLocation) => path.join(opts.lockfileDir, hoistedLocation))
         : [path.join(ctx.virtualStoreDir, dp.depPathToFilename(depPath), 'node_modules', pkgInfo.name)]
       if (pkgRoots.length === 0) {
-        throw new PnpmError('MISSING_HOISTED_LOCATIONS', `${depPath} is not found in hoistedLocations inside node_modules/.modules.yaml`, {
-          hint: 'If you installed your node_modules with pnpm older than v7.19.0, you may need to remove it and run "pnpm install"',
-        })
+        if (pkgSnapshot.optional) {
+          return
+        } else {
+          throw new PnpmError('MISSING_HOISTED_LOCATIONS', `${depPath} is not found in hoistedLocations inside node_modules/.modules.yaml`, {
+            hint: 'If you installed your node_modules with pnpm older than v7.19.0, you may need to remove it and run "pnpm install"',
+          })
+        }
       }
       const pkgRoot = pkgRoots[0]
       try {