refactor: create a package for hook types (#6380)

.changeset/silver-cats-own.md

@@ -0,0 +1,5 @@
+---
+"@pnpm/hooks.types": major
+---
+
+Initial release.

hooks/pnpmfile/package.json

@@ -33,9 +33,9 @@
     "@pnpm/pnpmfile": "workspace:*"
   },
   "dependencies": {
-    "@pnpm/core": "workspace:*",
     "@pnpm/core-loggers": "workspace:*",
     "@pnpm/error": "workspace:*",
+    "@pnpm/hooks.types": "workspace:*",
     "@pnpm/lockfile-types": "workspace:*",
     "@pnpm/store-controller-types": "workspace:*",
     "@pnpm/types": "workspace:*",

hooks/pnpmfile/src/requireHooks.ts

@@ -1,5 +1,5 @@
 import path from 'path'
-import type { PreResolutionHook, PreResolutionHookContext, PreResolutionHookLogger } from '@pnpm/core'
+import type { PreResolutionHook, PreResolutionHookContext, PreResolutionHookLogger } from '@pnpm/hooks.types'
 import { hookLogger } from '@pnpm/core-loggers'
 import pathAbsolute from 'path-absolute'
 import type { Lockfile } from '@pnpm/lockfile-types'

hooks/pnpmfile/tsconfig.json

@@ -25,10 +25,10 @@
       "path": "../../packages/types"
     },
     {
-      "path": "../../pkg-manager/core"
+      "path": "../../store/store-controller-types"
     },
     {
-      "path": "../../store/store-controller-types"
+      "path": "../types"
     }
   ],
   "composite": true

hooks/types/README.md

@@ -0,0 +1,15 @@
+# @pnpm/hooks.types
+
+> Types for hooks
+
+[![npm version](https://img.shields.io/npm/v/@pnpm/hooks.types.svg)](https://www.npmjs.com/package/@pnpm/hooks.types)
+
+## Installation
+
+```sh
+pnpm add @pnpm/hooks.types
+```
+
+## License
+
+MIT

hooks/types/package.json

@@ -0,0 +1,41 @@
+{
+  "name": "@pnpm/hooks.types",
+  "version": "0.0.0",
+  "description": "Types for hooks",
+  "main": "lib/index.js",
+  "types": "lib/index.d.ts",
+  "files": [
+    "lib",
+    "!*.map"
+  ],
+  "engines": {
+    "node": ">=16.14"
+  },
+  "scripts": {
+    "test": "pnpm run compile",
+    "prepublishOnly": "pnpm run compile",
+    "compile": "tsc --build && pnpm run lint --fix",
+    "lint": "eslint \"src/**/*.ts\""
+  },
+  "repository": "https://github.com/pnpm/pnpm/blob/main/hooks/types",
+  "keywords": [
+    "pnpm8",
+    "pnpm"
+  ],
+  "license": "MIT",
+  "bugs": {
+    "url": "https://github.com/pnpm/pnpm/issues"
+  },
+  "homepage": "https://github.com/pnpm/pnpm/blob/main/hooks/types#readme",
+  "devDependencies": {
+    "@pnpm/hooks.types": "workspace:*"
+  },
+  "dependencies": {
+    "@pnpm/lockfile-types": "workspace:*",
+    "@pnpm/types": "workspace:*"
+  },
+  "funding": "https://opencollective.com/pnpm",
+  "exports": {
+    ".": "./lib/index.js"
+  }
+}

pkg-manager/core/src/install/hooks.ts → hooks/types/src/index.ts

@@ -1,4 +1,4 @@
-import type { Lockfile } from '@pnpm/lockfile-file'
+import type { Lockfile } from '@pnpm/lockfile-types'
 import type { Registries } from '@pnpm/types'
 
 export interface PreResolutionHookContext {

hooks/types/tsconfig.json

@@ -0,0 +1,20 @@
+{
+  "extends": "@pnpm/tsconfig",
+  "compilerOptions": {
+    "outDir": "lib",
+    "rootDir": "src"
+  },
+  "include": [
+    "src/**/*.ts",
+    "../../__typings__/**/*.d.ts"
+  ],
+  "references": [
+    {
+      "path": "../../lockfile/lockfile-types"
+    },
+    {
+      "path": "../../packages/types"
+    }
+  ],
+  "composite": true
+}

hooks/types/tsconfig.lint.json

@@ -0,0 +1,8 @@
+{
+  "extends": "./tsconfig.json",
+  "include": [
+    "src/**/*.ts",
+    "test/**/*.ts",
+    "../../__typings__/**/*.d.ts"
+  ]
+}

pkg-manager/core/package.json

@@ -28,6 +28,7 @@
     "@pnpm/headless": "workspace:*",
     "@pnpm/hoist": "workspace:*",
     "@pnpm/hooks.read-package-hook": "workspace:*",
+    "@pnpm/hooks.types": "workspace:*",
     "@pnpm/lifecycle": "workspace:*",
     "@pnpm/link-bins": "workspace:*",
     "@pnpm/lockfile-file": "workspace:*",

pkg-manager/core/src/index.ts

@@ -8,7 +8,6 @@ export type {
 } from '@pnpm/types'
 export type { HoistingLimits } from '@pnpm/headless'
 export * from './api'
-export * from './install/hooks'
 
 export { type ProjectOptions, UnexpectedStoreError, UnexpectedVirtualStoreDirError } from '@pnpm/get-context'
 export type { InstallOptions } from './install/extendInstallOptions'

pkg-manager/core/src/install/extendInstallOptions.ts

@@ -17,7 +17,7 @@ import {
 } from '@pnpm/types'
 import { pnpmPkgJson } from '../pnpmPkgJson'
 import { type ReporterFunction } from '../types'
-import { type PreResolutionHookContext } from './hooks'
+import { type PreResolutionHookContext } from '@pnpm/hooks.types'
 
 export interface StrictInstallOptions {
   autoInstallPeers: boolean

pkg-manager/core/tsconfig.json

@@ -42,6 +42,9 @@
     {
       "path": "../../hooks/read-package-hook"
     },
+    {
+      "path": "../../hooks/types"
+    },
     {
       "path": "../../lockfile/filter-lockfile"
     },