style: update eslint (#6236)

__utils__/assert-project/src/index.ts

@@ -1,15 +1,15 @@
 import path from 'path'
 import { assertStore } from '@pnpm/assert-store'
 import { WANTED_LOCKFILE } from '@pnpm/constants'
-import { LockfileV6 as Lockfile, ProjectSnapshotV6 as ProjectSnapshot } from '@pnpm/lockfile-types'
-import { Modules, readModulesManifest } from '@pnpm/modules-yaml'
+import { type LockfileV6 as Lockfile, type ProjectSnapshotV6 as ProjectSnapshot } from '@pnpm/lockfile-types'
+import { type Modules, readModulesManifest } from '@pnpm/modules-yaml'
 import { REGISTRY_MOCK_PORT } from '@pnpm/registry-mock'
 import readYamlFile from 'read-yaml-file'
 import exists from 'path-exists'
 import writePkg from 'write-pkg'
 import isExecutable from './isExecutable'
 
-export { isExecutable, Modules }
+export { isExecutable, type Modules }
 
 export type RawLockfile = Lockfile & Partial<ProjectSnapshot>
 

__utils__/eslint-config/eslint.json

@@ -60,6 +60,7 @@
     "@typescript-eslint/dot-notation": "off",
     "@typescript-eslint/no-unnecessary-type-assertion": "off",
     "@typescript-eslint/type-annotation-spacing": "error",
+    "@typescript-eslint/ban-ts-comment": "off",
     "brace-style": [
         "error",
         "1tbs"

__utils__/eslint-config/package.json

@@ -25,8 +25,8 @@
   "dependencies": {
     "@typescript-eslint/eslint-plugin": "^5.54.0",
     "@typescript-eslint/parser": "^5.54.0",
-    "eslint": "^8.35.0",
-    "eslint-config-standard-with-typescript": "^26.0.0",
+    "eslint": "^8.36.0",
+    "eslint-config-standard-with-typescript": "^34.0.1",
     "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-n": "^15.6.1",
     "eslint-plugin-node": "^11.1.0",

__utils__/prepare/src/index.ts

@@ -1,13 +1,13 @@
 import fs from 'fs'
 import path from 'path'
-import { assertProject, Modules, Project } from '@pnpm/assert-project'
-import { ProjectManifest } from '@pnpm/types'
+import { assertProject, type Modules, type Project } from '@pnpm/assert-project'
+import { type ProjectManifest } from '@pnpm/types'
 import uniqueString from 'unique-string'
 import { sync as writeJson5File } from 'write-json5-file'
 import { sync as writeYamlFile } from 'write-yaml-file'
 import writePkg from 'write-pkg'
 
-export { Modules, Project }
+export type { Modules, Project }
 export type ManifestFormat = 'JSON' | 'JSON5' | 'YAML'
 
 // The testing folder should be outside of the project to avoid lookup in the project's node_modules

cli/cli-meta/src/index.ts

@@ -1,5 +1,5 @@
 import path from 'path'
-import { DependencyManifest } from '@pnpm/types'
+import { type DependencyManifest } from '@pnpm/types'
 import loadJsonFile from 'load-json-file'
 
 const defaultManifest = {

cli/cli-utils/src/getConfig.ts

@@ -1,5 +1,5 @@
 import { packageManager } from '@pnpm/cli-meta'
-import { getConfig as _getConfig, CliOptions } from '@pnpm/config'
+import { getConfig as _getConfig, type CliOptions } from '@pnpm/config'
 import { formatWarn } from '@pnpm/default-reporter'
 
 export async function getConfig (

cli/cli-utils/src/packageIsInstallable.ts

@@ -1,6 +1,6 @@
 import { packageManager } from '@pnpm/cli-meta'
 import { logger } from '@pnpm/logger'
-import { checkPackage, UnsupportedEngineError, WantedEngine } from '@pnpm/package-is-installable'
+import { checkPackage, UnsupportedEngineError, type WantedEngine } from '@pnpm/package-is-installable'
 
 export function packageIsInstallable (
   pkgPath: string,

cli/cli-utils/src/readProjectManifest.ts

@@ -1,5 +1,5 @@
 import * as utils from '@pnpm/read-project-manifest'
-import { ProjectManifest } from '@pnpm/types'
+import { type ProjectManifest } from '@pnpm/types'
 import { packageIsInstallable } from './packageIsInstallable'
 
 export async function readProjectManifest (

cli/default-reporter/src/index.ts

@@ -1,6 +1,6 @@
-import { Config } from '@pnpm/config'
-import * as logs from '@pnpm/core-loggers'
-import { LogLevel } from '@pnpm/logger'
+import { type Config } from '@pnpm/config'
+import type * as logs from '@pnpm/core-loggers'
+import { type LogLevel } from '@pnpm/logger'
 import * as Rx from 'rxjs'
 import { filter, map, mergeAll } from 'rxjs/operators'
 import createDiffer from 'ansi-diff'

cli/default-reporter/src/reportError.ts

@@ -1,8 +1,8 @@
-import { Config } from '@pnpm/config'
-import { Log } from '@pnpm/core-loggers'
-import { PnpmError } from '@pnpm/error'
+import { type Config } from '@pnpm/config'
+import { type Log } from '@pnpm/core-loggers'
+import { type PnpmError } from '@pnpm/error'
 import { renderPeerIssues } from '@pnpm/render-peer-issues'
-import { PeerDependencyIssuesByProjects } from '@pnpm/types'
+import { type PeerDependencyIssuesByProjects } from '@pnpm/types'
 import chalk from 'chalk'
 import equals from 'ramda/src/equals'
 import StackTracey from 'stacktracey'

cli/default-reporter/src/reporterForClient/index.ts

@@ -1,7 +1,7 @@
-import { Config } from '@pnpm/config'
-import * as logs from '@pnpm/core-loggers'
-import { LogLevel } from '@pnpm/logger'
-import * as Rx from 'rxjs'
+import { type Config } from '@pnpm/config'
+import type * as logs from '@pnpm/core-loggers'
+import { type LogLevel } from '@pnpm/logger'
+import type * as Rx from 'rxjs'
 import { throttleTime } from 'rxjs/operators'
 import { reportBigTarballProgress } from './reportBigTarballsProgress'
 import { reportContext } from './reportContext'

cli/default-reporter/src/reporterForClient/pkgsDiff.ts

@@ -1,5 +1,5 @@
-import * as logs from '@pnpm/core-loggers'
-import { PackageManifest } from '@pnpm/types'
+import type * as logs from '@pnpm/core-loggers'
+import { type PackageManifest } from '@pnpm/types'
 import * as Rx from 'rxjs'
 import { filter, map, mapTo, reduce, scan, startWith, take } from 'rxjs/operators'
 import mergeRight from 'ramda/src/mergeRight'

cli/default-reporter/src/reporterForClient/reportBigTarballsProgress.ts

@@ -1,5 +1,5 @@
-import { FetchingProgressLog } from '@pnpm/core-loggers'
-import * as Rx from 'rxjs'
+import { type FetchingProgressLog } from '@pnpm/core-loggers'
+import type * as Rx from 'rxjs'
 import { filter, map, startWith } from 'rxjs/operators'
 import prettyBytes from 'pretty-bytes'
 import {

cli/default-reporter/src/reporterForClient/reportContext.ts

@@ -1,5 +1,5 @@
 import path from 'path'
-import { ContextLog, PackageImportMethodLog } from '@pnpm/core-loggers'
+import { type ContextLog, type PackageImportMethodLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { map, take } from 'rxjs/operators'
 import normalize from 'normalize-path'

cli/default-reporter/src/reporterForClient/reportDeprecations.ts

@@ -1,4 +1,4 @@
-import { DeprecationLog } from '@pnpm/core-loggers'
+import { type DeprecationLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { map } from 'rxjs/operators'
 import chalk from 'chalk'

cli/default-reporter/src/reporterForClient/reportExecutionTime.ts

@@ -1,5 +1,5 @@
 import prettyMs from 'pretty-ms'
-import { ExecutionTimeLog } from '@pnpm/core-loggers'
+import { type ExecutionTimeLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { map, take } from 'rxjs/operators'
 

cli/default-reporter/src/reporterForClient/reportHooks.ts

@@ -1,4 +1,4 @@
-import { HookLog } from '@pnpm/core-loggers'
+import { type HookLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { map } from 'rxjs/operators'
 import chalk from 'chalk'

cli/default-reporter/src/reporterForClient/reportInstallChecks.ts

@@ -1,4 +1,4 @@
-import { InstallCheckLog } from '@pnpm/core-loggers'
+import { type InstallCheckLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { filter, map } from 'rxjs/operators'
 import { formatWarn } from './utils/formatWarn'

cli/default-reporter/src/reporterForClient/reportLifecycleScripts.ts

@@ -1,5 +1,5 @@
 import path from 'path'
-import { LifecycleLog } from '@pnpm/core-loggers'
+import { type LifecycleLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { buffer, filter, groupBy, map, mergeAll, mergeMap } from 'rxjs/operators'
 import chalk from 'chalk'

cli/default-reporter/src/reporterForClient/reportMisc.ts

@@ -1,7 +1,7 @@
 import os from 'os'
-import { Config } from '@pnpm/config'
-import { Log, RegistryLog } from '@pnpm/core-loggers'
-import { LogLevel } from '@pnpm/logger'
+import { type Config } from '@pnpm/config'
+import { type Log, type RegistryLog } from '@pnpm/core-loggers'
+import { type LogLevel } from '@pnpm/logger'
 import * as Rx from 'rxjs'
 import { filter, map } from 'rxjs/operators'
 import { reportError } from '../reportError'

cli/default-reporter/src/reporterForClient/reportPeerDependencyIssues.ts

@@ -1,4 +1,4 @@
-import { PeerDependencyIssuesLog } from '@pnpm/core-loggers'
+import { type PeerDependencyIssuesLog } from '@pnpm/core-loggers'
 import { renderPeerIssues } from '@pnpm/render-peer-issues'
 import * as Rx from 'rxjs'
 import { map, take } from 'rxjs/operators'

cli/default-reporter/src/reporterForClient/reportProgress.ts

@@ -1,4 +1,4 @@
-import { ProgressLog, StageLog } from '@pnpm/core-loggers'
+import { type ProgressLog, type StageLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { filter, map, mapTo, takeWhile, startWith, take } from 'rxjs/operators'
 import { hlValue } from './outputConstants'

cli/default-reporter/src/reporterForClient/reportRequestRetry.ts

@@ -1,4 +1,4 @@
-import { RequestRetryLog } from '@pnpm/core-loggers'
+import { type RequestRetryLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { map } from 'rxjs/operators'
 import prettyMilliseconds from 'pretty-ms'

cli/default-reporter/src/reporterForClient/reportScope.ts

@@ -1,4 +1,4 @@
-import { ScopeLog } from '@pnpm/core-loggers'
+import { type ScopeLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { map, take } from 'rxjs/operators'
 

cli/default-reporter/src/reporterForClient/reportSkippedOptionalDependencies.ts

@@ -1,4 +1,4 @@
-import { SkippedOptionalDependencyLog } from '@pnpm/core-loggers'
+import { type SkippedOptionalDependencyLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { filter, map } from 'rxjs/operators'
 

cli/default-reporter/src/reporterForClient/reportStats.ts

@@ -1,4 +1,4 @@
-import { StatsLog } from '@pnpm/core-loggers'
+import { type StatsLog } from '@pnpm/core-loggers'
 import * as Rx from 'rxjs'
 import { filter, take, reduce, map } from 'rxjs/operators'
 import chalk from 'chalk'

cli/default-reporter/src/reporterForClient/reportSummary.ts

@@ -1,19 +1,19 @@
 import path from 'path'
 import {
-  DeprecationLog,
-  PackageManifestLog,
-  RootLog,
-  SummaryLog,
+  type DeprecationLog,
+  type PackageManifestLog,
+  type RootLog,
+  type SummaryLog,
 } from '@pnpm/core-loggers'
-import { Config } from '@pnpm/config'
+import { type Config } from '@pnpm/config'
 import * as Rx from 'rxjs'
 import { map, take } from 'rxjs/operators'
 import chalk from 'chalk'
 import semver from 'semver'
 import { EOL } from '../constants'
 import {
   getPkgsDiff,
-  PackageDiff,
+  type PackageDiff,
   propertyByDependencyType,
 } from './pkgsDiff'
 import {

cli/default-reporter/src/reporterForClient/reportUpdateCheck.ts

@@ -1,4 +1,4 @@
-import { UpdateCheckLog } from '@pnpm/core-loggers'
+import { type UpdateCheckLog } from '@pnpm/core-loggers'
 import boxen from 'boxen'
 import chalk from 'chalk'
 import * as Rx from 'rxjs'

cli/default-reporter/src/reporterForServer.ts

@@ -1,6 +1,6 @@
-import { Config } from '@pnpm/config'
-import { Log } from '@pnpm/core-loggers'
-import * as Rx from 'rxjs'
+import { type Config } from '@pnpm/config'
+import { type Log } from '@pnpm/core-loggers'
+import type * as Rx from 'rxjs'
 import chalk from 'chalk'
 import { reportError } from './reportError'
 

cli/default-reporter/test/filterLogHook.ts

@@ -1,4 +1,4 @@
-import { Log } from '@pnpm/core-loggers'
+import { type Log } from '@pnpm/core-loggers'
 import { toOutput$ } from '@pnpm/default-reporter'
 import { logger, createStreamParser } from '@pnpm/logger'
 

cli/default-reporter/test/index.ts

@@ -1,6 +1,6 @@
 /// <reference path="../../../__typings__/index.d.ts"/>
 import path from 'path'
-import { Config } from '@pnpm/config'
+import { type Config } from '@pnpm/config'
 import {
   deprecationLogger,
   hookLogger,

cli/default-reporter/test/reportingProgress.ts

@@ -1,4 +1,4 @@
-import { Config } from '@pnpm/config'
+import { type Config } from '@pnpm/config'
 import {
   fetchingProgressLogger,
   progressLogger,

cli/default-reporter/test/reportingScope.ts

@@ -1,4 +1,4 @@
-import { Config } from '@pnpm/config'
+import { type Config } from '@pnpm/config'
 import { scopeLogger } from '@pnpm/core-loggers'
 import { toOutput$ } from '@pnpm/default-reporter'
 import { createStreamParser } from '@pnpm/logger'

cli/default-reporter/test/reportingUpdateCheck.ts

@@ -1,4 +1,4 @@
-import { Config } from '@pnpm/config'
+import { type Config } from '@pnpm/config'
 import { updateCheckLogger } from '@pnpm/core-loggers'
 import { toOutput$ } from '@pnpm/default-reporter'
 import { createStreamParser } from '@pnpm/logger'

cli/parse-cli-args/test/index.ts

@@ -1,5 +1,5 @@
 import os from 'os'
-import { PnpmError } from '@pnpm/error'
+import { type PnpmError } from '@pnpm/error'
 import { parseCliArgs } from '@pnpm/parse-cli-args'
 import tempy from 'tempy'
 

config/config/src/Config.ts

@@ -1,8 +1,8 @@
 import {
-  Project,
-  ProjectManifest,
-  ProjectsGraph,
-  Registries,
+  type Project,
+  type ProjectManifest,
+  type ProjectsGraph,
+  type Registries,
 } from '@pnpm/types'
 import type { Hooks } from '@pnpm/pnpmfile'
 

config/config/src/index.ts

@@ -18,15 +18,15 @@ import { checkGlobalBinDir } from './checkGlobalBinDir'
 import { getScopeRegistries } from './getScopeRegistries'
 import { getCacheDir, getConfigDir, getDataDir, getStateDir } from './dirs'
 import {
-  Config,
-  ConfigWithDeprecatedSettings,
-  UniversalOptions,
+  type Config,
+  type ConfigWithDeprecatedSettings,
+  type UniversalOptions,
 } from './Config'
 import { getWorkspaceConcurrency } from './concurrency'
 
 export * from './readLocalConfig'
 
-export { Config, UniversalOptions }
+export type { Config, UniversalOptions }
 
 const npmDefaults = loadNpmConf.defaults
 

config/config/test/index.ts

@@ -4,7 +4,7 @@ import path from 'path'
 import PATH from 'path-name'
 import { getCurrentBranch } from '@pnpm/git-utils'
 import { getConfig } from '@pnpm/config'
-import { PnpmError } from '@pnpm/error'
+import { type PnpmError } from '@pnpm/error'
 import loadNpmConf from '@pnpm/npm-conf'
 import { prepare, prepareEmpty } from '@pnpm/prepare'
 import { fixtures } from '@pnpm/test-fixtures'

config/normalize-registries/src/index.ts

@@ -1,4 +1,4 @@
-import { Registries } from '@pnpm/types'
+import { type Registries } from '@pnpm/types'
 import normalizeRegistryUrl from 'normalize-registry-url'
 import mapValues from 'ramda/src/map'
 

config/package-is-installable/src/index.ts

@@ -2,17 +2,17 @@ import {
   installCheckLogger,
   skippedOptionalDependencyLogger,
 } from '@pnpm/core-loggers'
-import { checkEngine, UnsupportedEngineError, WantedEngine } from './checkEngine'
+import { checkEngine, UnsupportedEngineError, type WantedEngine } from './checkEngine'
 import { checkPlatform, UnsupportedPlatformError } from './checkPlatform'
 import { getSystemNodeVersion } from './getSystemNodeVersion'
 
-export { Engine } from './checkEngine'
-export { Platform, WantedPlatform } from './checkPlatform'
+export type { Engine } from './checkEngine'
+export type { Platform, WantedPlatform } from './checkPlatform'
 
 export {
   UnsupportedEngineError,
   UnsupportedPlatformError,
-  WantedEngine,
+  type WantedEngine,
 }
 
 export function packageIsInstallable (

config/pick-registry-for-package/src/index.ts

@@ -1,4 +1,4 @@
-import { Registries } from '@pnpm/types'
+import { type Registries } from '@pnpm/types'
 
 export function pickRegistryForPackage (registries: Registries, packageName: string, pref?: string) {
   const scope = getScope(packageName, pref)

config/plugin-commands-config/src/ConfigCommandOptions.ts

@@ -1,4 +1,4 @@
-import { Config } from '@pnpm/config'
+import { type Config } from '@pnpm/config'
 
 export type ConfigCommandOptions = Pick<Config,
 | 'configDir'

config/plugin-commands-config/src/config.ts

@@ -4,7 +4,7 @@ import renderHelp from 'render-help'
 import { configGet } from './configGet'
 import { configSet } from './configSet'
 import { configList } from './configList'
-import { ConfigCommandOptions } from './ConfigCommandOptions'
+import { type ConfigCommandOptions } from './ConfigCommandOptions'
 
 export function rcOptionsTypes () {
   return {}

config/plugin-commands-config/src/configGet.ts

@@ -1,4 +1,4 @@
-import { ConfigCommandOptions } from './ConfigCommandOptions'
+import { type ConfigCommandOptions } from './ConfigCommandOptions'
 
 export function configGet (opts: ConfigCommandOptions, key: string) {
   return opts.rawConfig[key]