perf: reduce memory usage

pnpm · May 15, 2024 · f5f9c05 · f5f9c05
1 parent 7113126
commit f5f9c05
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/pkg-manager/resolve-dependencies/src/resolveDependencies.ts b/pkg-manager/resolve-dependencies/src/resolveDependencies.ts
@@ -81,7 +81,6 @@ export interface ChildrenMap {
 }
 
 export type DependenciesTreeNode<T> = {
-  parentNodeId: string
   children: (() => ChildrenMap) | ChildrenMap
   installable: boolean
 } & ({
@@ -752,7 +751,6 @@ async function resolveDependenciesOfDependency (
   if (resolveDependencyResult == null) return { resolveDependencyResult: null }
   if (resolveDependencyResult.isLinkedDependency) {
     ctx.dependenciesTree.set(createNodeIdForLinkedLocalPkg(ctx.lockfileDir, resolveDependencyResult.resolution.directory), {
-      parentNodeId: options.parentPkg.nodeId,
       children: {},
       depth: -1,
       installable: true,
@@ -901,7 +899,6 @@ async function resolveChildren (
     depPath: child.depPath,
   }))
   ctx.dependenciesTree.set(parentPkg.nodeId, {
-    parentNodeId,
     children: pkgAddresses.reduce((chn, child) => {
       chn[child.alias] = (child as PkgAddress).nodeId ?? child.pkgId
       return chn

diff --git a/pkg-manager/resolve-dependencies/src/resolveDependencyTree.ts b/pkg-manager/resolve-dependencies/src/resolveDependencyTree.ts
@@ -206,7 +206,6 @@ export async function resolveDependencyTree<T> (
 
   ctx.pendingNodes.forEach((pendingNode) => {
     ctx.dependenciesTree.set(pendingNode.nodeId, {
-      parentNodeId: pendingNode.parentNodeId,
       children: () => buildTree(ctx, pendingNode.nodeId, pendingNode.resolvedPackage.id,
         pendingNode.parentDepPaths,
         ctx.childrenByParentDepPath[pendingNode.resolvedPackage.depPath], pendingNode.depth + 1, pendingNode.installable),
@@ -290,7 +289,6 @@ function buildTree (
     childrenNodeIds[child.alias] = childNodeId
     installable = installable || !ctx.skipped.has(child.depPath)
     ctx.dependenciesTree.set(childNodeId, {
-      parentNodeId,
       children: () => buildTree(ctx,
         childNodeId,
         child.depPath,

diff --git a/pkg-manager/resolve-dependencies/src/resolvePeers.ts b/pkg-manager/resolve-dependencies/src/resolvePeers.ts
@@ -649,13 +649,11 @@ function parentPkgsHaveSingleOccurrence (parentPkgs: Record<string, ParentPkgInf
 // So we need to merge all the children of all the parent packages with same ID as the resolved package.
 // This way we get all the children that were removed, when ending cycles.
 function getPreviouslyResolvedChildren<T extends PartialResolvedPackage> (parentNodeIds: string[], parentDepPathsChain: string[], dependenciesTree: DependenciesTree<T>, ownDepPath: string): ChildrenMap {
-  const parentIds = [...parentNodeIds]
-  const parentDepPaths = [...parentDepPathsChain]
   const allChildren: ChildrenMap = {}
 
-  if (!ownDepPath || !parentDepPaths.includes(ownDepPath)) return allChildren
+  if (!ownDepPath || !parentDepPathsChain.includes(ownDepPath)) return allChildren
 
-  for (const parentNodeId of parentIds.reverse()) {
+  for (const parentNodeId of [...parentNodeIds].reverse()) {
     const parentNode = dependenciesTree.get(parentNodeId)!
     if ((parentNode.resolvedPackage as T).depPath === ownDepPath) {
       if (typeof parentNode.children === 'function') {