deploy uses monorepo root for output instead of working dir or absolute path

[AWare]

pnpm version: 7.5.0

Code to reproduce the issue:

say you're in a project 'p' within a monorepo

> pnpm --filter p deploy dist
> pnpm --filter p deploy $(pwd)/dist

Expected behavior:

I'd expect them both to put them within the current working dir.

Actual behavior:

it will put dist within the root of the monorepo,

Additional information:

it would also be really handy to infer the package from the working directory so filter can be omitted

Edit: apologies, just realised I got expected and actual the wrong way round

[zkochan]

I don't have objections to changing it, but I would be interested in more opinions. cc @pnpm/collaborators

[shellscape]

please allow me some time to think about this. it's a very complex question.

[DRoet]

I think inferring the package/workspace from the working directory would be a nice addition. that's kind of what I expected when first running pnpm deploy without any options.

[JounQin]

This would a breaking change, and personally I'm always using dist/packageName, maybe we add pattern support like dist/$pkg + packages/$pkg/dist?

[zkochan]

This command is experimental. Breaking changes are allowed.

[LeviticusMB]

I must say I was a bit surprised that pnpm --filter=... deploy /opt/foo/ didn't install anything at all in /opt.

[zkochan]

@shellscape did you think about it?

A PR is submitted but I don't see enough feedback yet.

[shellscape]

I've been sick the last few days. I'll weigh in tomorrow

[AWare]

If you're using ${workspaceDir}/dist/${pkg} then I'd wager that it's likely that when you build, your working directory might also be ${workspaceDir} whereas if you use ${workspaceDir}/${pkg}/dist, it's likely that you're going to be in ${workspaceDir}/${pkg}. So I'd posture that using the working dir is more natural for both cases (and matches most other things you'd be doing in the shell).

Regardless of where the target is relative to, absolute paths would make it much easier to use.

Also, were this adopted, a default filter of . would be nice to go alongside it- but I suspect that is where it gets complicated.

[AWare]

@shellscape did you have any objections to this?

[shellscape]

Apologies. I've been sick this past week and have not been able to get back to this.

[AWare]

Hope you're feeling better soon.

[AWare]

Would it be preferred if the change just allowed absolute paths to be used instead of changing the base path?

[AWare]

@zkochan / @shellscape is there anything that I can do to help get #5026 reviewed & approved? the comments so far seem generally in favour, and I believe that I have addressed any objections satisfactorily. I'd really like to start using deploy in my projects at work, and am currently held up on this.

[AWare]

thanks @zkochan 👍