fix: plugin-commands-deploy use path resolve on deploy target dir #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry (pnpm#4980) Previously the deploy target directory was specified as a relative path to the workspace project root. This meant that absolute paths could not be used. Now this uses the current working directory and allows absolute paths, this is more in line with users expectations of unix command behaivour. close pnpm#4980
|
💖 Thanks for opening this pull request! 💖 |
zkochan
approved these changes
Jul 27, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Jul 29, 2022
This was referenced Aug 10, 2022
kodiakhq bot
pushed a commit
to mheob/config
that referenced
this pull request
Aug 13, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pnpm](https://pnpm.io) ([source](https://togithub.com/pnpm/pnpm)) | [`7.6.0` -> `7.9.0`](https://renovatebot.com/diffs/npm/pnpm/7.6.0/7.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pnpm/pnpm</summary> ### [`v7.9.0`](https://togithub.com/pnpm/pnpm/releases/tag/v7.9.0) [Compare Source](https://togithub.com/pnpm/pnpm/compare/v7.8.0...v7.9.0) #### Minor Changes - When `ignore-dep-scripts` is `true`, ignore scripts of dependencies but run the scripts of the project. - When `ignore-compatibility-db` is set to `true`, the [compatibility database](https://togithub.com/yarnpkg/berry/blob/master/packages/yarnpkg-extensions/sources/index.ts) will not be used to patch dependencies [#​5132](https://togithub.com/pnpm/pnpm/issues/5132). - Print the versions of packages in peer dependency warnings and errors. - Support a new hook for passing a custom package importer to the store controller. #### Patch Changes - Don't print the same deprecation warning multiple times. - On POSIX `pnpm setup` should suggest users to source the config instead of restarting the terminal. - Installing a package with `bin` that points to an `.exe` file on Windows [#​5159](https://togithub.com/pnpm/pnpm/issues/5159). - Fix bug where the package manifest was not resolved if `verify-store-integrity` is set to `false`. - Fix sorting of keys in lockfile to make it more deterministic and prevent unnecessary churn in the lockfile [#​5151](https://togithub.com/pnpm/pnpm/pull/5151). - Don't create a separate bundle for pnpx. #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a> </td> </tr> </tbody> </table> ### [`v7.8.0`](https://togithub.com/pnpm/pnpm/releases/tag/v7.8.0) [Compare Source](https://togithub.com/pnpm/pnpm/compare/v7.7.1...v7.8.0) #### Minor Changes - When `publishConfig.directory` is set, only symlink it to other workspace projects if `publishConfig.linkDirectory` is set to `true`. Otherwise, only use it for publishing [#​5115](https://togithub.com/pnpm/pnpm/issues/5115). #### Patch Changes - Don't incorrectly identify a lockfile out-of-date when the package has a publishConfig.directory field [#​5124](https://togithub.com/pnpm/pnpm/issues/5124). - Don't crash when a config file contains a setting with an env variable that doesn't exist [#​5093](https://togithub.com/pnpm/pnpm/issues/5093). #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a> </td> </tr> </tbody> </table> #### What's Changed * fix: don't incorrectly identify a lockfile out-of-date by @​zkochan in pnpm/pnpm#5126 * feat: publishConfig.linkDirectory by @​zkochan in pnpm/pnpm#5125 * fix: don't crash on a .npmrc with missing env var by @​zkochan in pnpm/pnpm#5127 * chore: fix typo by @​LuciNyan in pnpm/pnpm#5128 #### New Contributors * @​LuciNyan made their first contribution in pnpm/pnpm#5128 **Full Changelog**: pnpm/pnpm@v7.7.1...v7.8.0 ### [`v7.7.1`](https://togithub.com/pnpm/pnpm/releases/tag/v7.7.1) [Compare Source](https://togithub.com/pnpm/pnpm/compare/v7.7.0...v7.7.1) #### Patch Changes - pnpm should not consider a lockfile out-of-date if `auto-install-peers` is set to `true` and the peer dependency is in `devDependencies` or `optionalDependencies` [#​5080](https://togithub.com/pnpm/pnpm/issues/5080). - Don't incorrectly consider a lockfile out-of-date when `workspace:^` or `workspace:~` version specs are used in a workspace. #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a> </td> </tr> </tbody> </table> #### What's Changed * fix: frozen install in a project with peer deps and `auto-install-peers=true` by @​zkochan in pnpm/pnpm#5120 * fix: don't incorrectly consider a lockfile to be out-of-date by @​zkochan in pnpm/pnpm#5121 **Full Changelog**: pnpm/pnpm@v7.7.0...v7.7.1 ### [`v7.7.0`](https://togithub.com/pnpm/pnpm/releases/tag/v7.7.0) [Compare Source](https://togithub.com/pnpm/pnpm/compare/v7.6.0...v7.7.0) #### Minor Changes - Add experimental lockfile format that should merge conflict less in the `importers` section. Enabled by setting the `use-inline-specifiers-lockfile-format = true` feature flag in `.npmrc`. If this feature flag is committed to a repo, we recommend setting the minimum allowed version of pnpm to this release in the `package.json` `engines` field. Once this is set, older pnpm versions will throw on invalid lockfile versions. - Add `publishDirectory` field to the lockfile and relink the project when it changes. - `verify-store-integrity=false` makes pnpm skip checking the integrities of files in the global content-addressable store. - Allow to set `only-built-dependencies[]` through `.npmrc`. #### Patch Changes - It should be possible to publish a package with local dependencies from a custom publish directory (set via `publishConfig.directory`) [#​3901](https://togithub.com/pnpm/pnpm/issues/3901#issuecomment-1194156886). - `pnpm deploy` should inject local dependencies of all types (dependencies, optionalDependencies, devDependencies) [#​5078](https://togithub.com/pnpm/pnpm/issues/5078). - When a project in a workspace has a `publishConfig.directory` set, dependent projects should install the project from that directory [#​3901](https://togithub.com/pnpm/pnpm/issues/3901) - **pnpm deploy**: accept absolute paths and use cwd instead of workspaceDir for deploy target directory [#​4980](https://togithub.com/pnpm/pnpm/issues/4980). - **pnpm setup** should update `.zshrc` in the right directory when a `$ZDOTDIR` is set. #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://nhost.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/nhost.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/novu.svg" width="180"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/prisma.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/leniolabs.jpg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/vercel.svg" width="180"></a> </td> <td align="center" valign="middle"> <a href="https://www.takeshape.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://raw.githubusercontent.com/pnpm/pnpm.github.io/main/static/img/users/takeshape.svg" width="280"></a> </td> </tr> </tbody> </table> #### What's Changed * fix(deploy): inject all types of deps by @​zkochan in pnpm/pnpm#5084 * fix(make-dedicated-lockfile): prepublishOnly script is automatically … by @​zkochan in pnpm/pnpm#5083 * fix: symlink a workspace pkg correctly, when it has a custom publish dir by @​zkochan in pnpm/pnpm#5089 * feat: add experimental use-inline-specifiers-lockfile-format by @​gluxon in pnpm/pnpm#5091 * fix: plugin-commands-deploy use path resolve on deploy target dir by @​AWare in pnpm/pnpm#5026 * fix: relink the project when its publish directory changes by @​zkochan in pnpm/pnpm#5109 * fix: don't include specifiers field in new experimental lockfile format by @​zkochan in pnpm/pnpm#5110 * feat: verify-store-integrity by @​zkochan in pnpm/pnpm#5112 #### New Contributors * @​AWare made their first contribution in pnpm/pnpm#5026 **Full Changelog**: pnpm/pnpm@v7.6.0...v7.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/mheob/config).
](https://renovatebot.com){kind=link}
This was referenced Aug 13, 2022
This was referenced Aug 20, 2022
This was referenced Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of the deploy command as discussed in #4980 to use the working directory and to accept absolute paths.
close #4980