Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISSING_HOISTED_LOCATIONS error thrown for skipped dependencies #6092

Closed
douglasward opened this issue Feb 16, 2023 · 1 comment
Closed

MISSING_HOISTED_LOCATIONS error thrown for skipped dependencies #6092

douglasward opened this issue Feb 16, 2023 · 1 comment

Comments

@douglasward
Copy link
Contributor

douglasward commented Feb 16, 2023

When using node-linker=hoisted the MISSING_HOISTED_LOCATIONS error (added by #5819) is thrown if a skipped dependency is missing in the hoisted locations in node_modules/.modules.yaml.

This makes it impossible to have a successful install.

pnpm version: 7.27.0

Expected behavior:

Skipped dependencies should not be taken into account for the MISSING_HOISTED_LOCATIONS error.

Actual behavior:

The MISSING_HOISTED_LOCATIONS is thrown.

Additional information:

Line where error is thrown: https://github.com/pnpm/pnpm/blob/v7.26.3/exec/plugin-commands-rebuild/src/implementation/index.ts#L283

If something like the following is added in the line above then the install succeeds as expected:

regx = new RegExp(pkgInfo.name, 'i');
if (Array.from(ctx.skipped).some(name => regx.test(name))){
  return;
}
  • node -v prints: v16.17.1
  • Windows, macOS, or Linux?: macOS
@brentdurksen
Copy link

This is blocking our deployment of pnpm. We are using node-linker=hoisted in .npmrc to support Meteor, and optional dependency fsevents (macOS specific) blocks pnpm install on non-macOS operating systems, specifically Linux. We are receiving the same MISSING_HOISTED_LOCATIONS error as documented above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants