do not throw MISSING_HOISTED_LOCATIONS for optional packages #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasward
force-pushed
the
fix-missing-hoisted-locations
branch
from
3a3abd6
to
d5a58c2
Compare
zkochan
approved these changes
May 16, 2023
|
facing same issue on pnpm:8.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using node-linker=hoisted the MISSING_HOISTED_LOCATIONS error (added by #5819) is thrown if an optional dependency is missing in the hoisted locations in
node_modules/.modules.yaml.This makes it impossible to have a successful install.
See #6092 which was similar but for skipped dependencies.