feat: support onlyBuiltDependencies #4002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ci failed for the test case |
|
Yes. I'm debugging it. |
|
hi! I spent 3 hours and really cannot find out why the test fails. Can you help me? I handle the new option like |
zkochan
reviewed
Nov 17, 2021
SukkaW
reviewed
Nov 17, 2021
SukkaW
reviewed
Nov 17, 2021
Comment on lines
+881
to
+893
| let requiresBuild: boolean | undefined | ||
| if (options.onlyBuiltDependencies === false || options.onlyBuiltDependencies.has(options.pkg.name)) { | ||
| // No onlyBuiltDependencies is specified or this package is explicitly allowed. | ||
| if (options.neverBuiltDependencies.has(options.pkg.name)) { | ||
| // This package is explicitly listed. | ||
| requiresBuild = false | ||
| } else { | ||
| // default resolution | ||
| requiresBuild = options.dependencyLockfile != null ? Boolean(options.dependencyLockfile.requiresBuild) : undefined | ||
| } | ||
| } else { | ||
| requiresBuild = false | ||
| } |
There was a problem hiding this comment.
Suggested change
| let requiresBuild: boolean | undefined | |
| if (options.onlyBuiltDependencies === false || options.onlyBuiltDependencies.has(options.pkg.name)) { | |
| // No onlyBuiltDependencies is specified or this package is explicitly allowed. | |
| if (options.neverBuiltDependencies.has(options.pkg.name)) { | |
| // This package is explicitly listed. | |
| requiresBuild = false | |
| } else { | |
| // default resolution | |
| requiresBuild = options.dependencyLockfile != null ? Boolean(options.dependencyLockfile.requiresBuild) : undefined | |
| } | |
| } else { | |
| requiresBuild = false | |
| } | |
| let requiresBuild: boolean | undefined | |
| if ( | |
| options.neverBuiltDependencies.has(options.pkg.name) | |
| || ( | |
| options.onlyBuiltDependencies !== false | |
| && !options.onlyBuiltDependencies.has(options.pkg.name) | |
| ) | |
| ) { | |
| requiresBuild = false; | |
| } else if (options.dependencyLockfile != null) { | |
| requiresBuild = Boolean(options.dependencyLockfile.requiresBuild); | |
| } else { | |
| requiresBuild = undefined; | |
| } |
I'll check this week. |
|
Looks like you did not allow others to push to your pull request. So I had to make another one #4014 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4001