Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed-readme option #4265

Merged
merged 1 commit into from Jan 20, 2022
Merged

feat: embed-readme option #4265

merged 1 commit into from Jan 20, 2022

Conversation

dangreen
Copy link
Contributor

@zkochan
Copy link
Member

zkochan commented Jan 20, 2022

Thanks for making the PR.

Let's add the new setting to @pnpm/confg and maybe make it true by default? We can make it false in v7

In any case, I don't think people will use it as a CLI option, they will just set it in a .npmrc file.

@dangreen
Copy link
Contributor Author

@zkochan

Let's add the new setting to @pnpm/confg

Into Config interface, or where?

@zkochan
Copy link
Member

zkochan commented Jan 20, 2022

in these places also

bail: Boolean,

bail: true,

@dangreen
Copy link
Contributor Author

@zkochan

maybe make it true by default? We can make it false in v7

It absolutely should be false by default. For now, made it true

@zkochan
Copy link
Member

zkochan commented Jan 20, 2022

One last thing.

Run pnpm changeset in the root of the repository and describe your changes. The resulting files should be committed as they will be used during release.

@dangreen
Copy link
Contributor Author

@zkochan Will nice if some words about changeset were in the contribution guide.

@dangreen
Copy link
Contributor Author

Will nice if some words about changeset were in the contribution guide.

ooops

Run pnpm changeset in the root of the repository and describe your changes. The resulting files should be committed as they will be used during release.

just now found it

@zkochan
Copy link
Member

zkochan commented Jan 20, 2022

There is https://github.com/pnpm/pnpm/blob/main/CONTRIBUTING.md#submitting-a-pull-request-pr

I copied that text about changesets from CONTRIBUTING.

of course, we can add more info, and duplicate it in the PR template.

@zkochan zkochan merged commit b7566b9 into pnpm:main Jan 20, 2022
@dangreen dangreen deleted the feat-embed-readme branch January 20, 2022 17:21
@zkochan zkochan added this to the v6.28 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants