New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: embed-readme option #4265
Conversation
Thanks for making the PR. Let's add the new setting to In any case, I don't think people will use it as a CLI option, they will just set it in a |
Into |
in these places also pnpm/packages/config/src/index.ts Line 40 in 1d013d7
pnpm/packages/config/src/index.ts Line 175 in 1d013d7
|
It absolutely should be |
One last thing. Run |
@zkochan Will nice if some words about changeset were in the contribution guide. |
ooops
just now found it |
There is https://github.com/pnpm/pnpm/blob/main/CONTRIBUTING.md#submitting-a-pull-request-pr I copied that text about changesets from CONTRIBUTING. of course, we can add more info, and duplicate it in the PR template. |
#4091 (comment)