feat: add support of the update-notifier configuration option #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
reviewed
Jan 27, 2022
packages/pnpm/src/checkForUpdates.ts
Outdated
| @@ -14,6 +14,9 @@ interface State { | |||
| const UPDATE_CHECK_FREQUENCY = 24 * 60 * 60 * 1000 // 1 day | |||
|
|
|||
| export default async function (config: Config) { | |||
| if (!config.updateNotifier) { | |||
There was a problem hiding this comment.
just don't run this function in this case. There are already lots of conditions in main.ts:
pnpm/packages/pnpm/src/main.ts
Lines 228 to 237 in 4e778cf
There was a problem hiding this comment.
Yep I saw that but I was a bit unsure on how to cover it with a test here.
The configuration option `update-notifier` allows users to disable the update verification. This is interesting when pnpm is installed from another package manager because the given instructions will not be accurate. The `update-notifier` option exists in NPM so it can also ease the migration to pnpm. (https://docs.npmjs.com/cli/v8/using-npm/config#update-notifier). Closes #4158.
zkochan
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration option
update-notifierallows users to disable the update verification. This is interesting when pnpm is installed from another package manager because the given instructions will not be accurate. Theupdate-notifieroption exists in NPM so it can also ease the migration to pnpm.Closes #4158.