feat: run scripts without --unsafe-perm

.changeset/silent-eagles-rest.md

@@ -0,0 +1,6 @@
+---
+"@pnpm/lifecycle": major
+"pnpm": major
+---
+
+Allow to execute a lifecycle script in a directory that doesn't match the package's name. Previously this was only allowed with the `--unsafe-perm` CLI option [#3709](https://github.com/pnpm/pnpm/issues/3709).

packages/core/test/install/lifecycleScripts.ts

@@ -128,24 +128,6 @@ test('run install scripts in the current project when its name is different than
   expect(output).toStrictEqual(['preinstall', 'install', 'postinstall'])
 })
 
-test('do not run install scripts if unsafePerm is false', async () => {
-  prepareEmpty()
-  const opts = await testDefaults({ fastUnpack: false, unsafePerm: false })
-  const manifest = await addDependenciesToPackage({
-    name: 'different-name',
-    scripts: {
-      install: 'node -e "process.stdout.write(\'install\')" | json-append output.json',
-      postinstall: 'node -e "process.stdout.write(\'postinstall\')" | json-append output.json',
-      preinstall: 'node -e "process.stdout.write(\'preinstall\')" | json-append output.json',
-    },
-  }, ['json-append@1.1.1'], opts)
-  await install(manifest, opts)
-
-  const outputExists = await exists('output.json')
-
-  expect(outputExists).toBeFalsy()
-})
-
 test('installation fails if lifecycle script fails', async () => {
   prepareEmpty()
 

packages/lifecycle/package.json

@@ -37,7 +37,7 @@
   "dependencies": {
     "@pnpm/core-loggers": "workspace:6.1.3",
     "@pnpm/directory-fetcher": "workspace:1.0.5",
-    "@pnpm/npm-lifecycle": "^1.0.4",
+    "@pnpm/npm-lifecycle": "^2.0.0-1",
     "@pnpm/read-package-json": "workspace:5.0.10",
     "@pnpm/store-controller-types": "workspace:11.0.11",
     "@pnpm/types": "workspace:7.9.0",

packages/pnpm/test/install/lifecycleScripts.ts

@@ -116,24 +116,20 @@ test('dependency should not be added to package.json and lockfile if it was not
 test('node-gyp is in the PATH', async () => {
   prepare({
     scripts: {
-      test: 'node-gyp --help',
+      test: 'echo $PATH && node-gyp --help',
     },
   })
 
-  // `npm test` adds node-gyp to the PATH
-  // it is removed here to test that pnpm adds it
-  const initialPath = process.env.PATH
-
-  if (typeof initialPath !== 'string') throw new Error('PATH is not defined')
-
-  process.env[PATH] = initialPath
-    .split(path.delimiter)
-    .filter((p: string) => !p.includes('node-gyp-bin') && !p.includes('npm'))
-    .join(path.delimiter)
-
-  const result = execPnpmSync(['test'])
-
-  process.env[PATH] = initialPath
+  const result = execPnpmSync(['test'], {
+    env: {
+      // `npm test` adds node-gyp to the PATH
+      // it is removed here to test that pnpm adds it
+      [PATH]: process.env[PATH]!
+        .split(path.delimiter)
+        .filter((p: string) => !p.includes('node-gyp-bin'))
+        .join(path.delimiter),
+    },
+  })
 
   expect(result.status).toBe(0)
 })