fix filter-prod flag including all workspace pkgs

[maxwellium]

f48d46e appears to have surfaced a regression where the exclusion filter for workspace root broke was inserted without followProdDepsOnly. i guess we didn't notice earlier because filterProd together with workspaceRoot is an edge-case ;)

[welcome]

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

[zkochan]

I am not sure what the issue is. Add a test, please.

[noorulh06]

Any updates on this?
I am also facing the same issue.
My Project looks like:

• ui
  • apps
    • guest
    • editor
  • pkgs
    • widgets
    • builder

builder is added as devDependency in ui/apps/guest but as a dependency of ui/apps/editor. When I use pnpm --filter ...builder exec node -e 'console.log(require(./package.json).name)' I get both guest and editor, but when I tried pnpm --filter-prod ...builder exec node -e 'console.log(require(./package.json).name)' I am getting all the packages where it should only print editor and builder.

[noorulh06]

Also will it be fine if I create a new PR for this issue?

[zkochan]

ok, just add a test.

[noorulh06]

I have wrote the test case but getting lint errors in untouched files while pushing the changes. Should I ignore that lint rule for the project?
There are total 125 of the following error:
error Invalid type "any" of template literal expression @typescript-eslint/restrict-template-expressions

[noorulh06]

[zkochan]

Maybe you need to run pnpm -w compile.
but in any case, you can git push --no-verify

[zkochan]

covered by #5437