Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use irreversible-delete in pnpm patch-commit #5008

Merged
merged 1 commit into from Jul 11, 2022

Conversation

webstrand
Copy link
Contributor

Avoid retaining a copy of the contents of files deleted during patching

fixes #5003

@webstrand webstrand requested a review from zkochan as a code owner July 11, 2022 14:33
@welcome
Copy link

welcome bot commented Jul 11, 2022

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

Avoid retaining a copy of the contents of files deleted during patching
@webstrand
Copy link
Contributor Author

fixed the issue of fs.rmSync not being available in Node.js v16.x, replaced it with fs.unlink

@zkochan zkochan merged commit f0cd8b0 into pnpm:main Jul 11, 2022
@welcome
Copy link

welcome bot commented Jul 11, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --irreversible-delete to git diff in patch-commit
2 participants