chore(deps): upgrade sinon to v14 #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade sinon throughout packages to 14.0.0
|
If you want to update many dependencies, use one PR please. |
Ok sounds good, some maintainers are very picky and don't want more than one dep upgraded to keep the scope of PR small. |
|
I understand that. But these are only version updates. No code changes at all. I don't see a reason to make a separate PR for each dependency update. |
This was referenced Jul 22, 2022
This was referenced Aug 21, 2022
Closed
1 task
This was referenced Aug 22, 2022
Closed
This was referenced Aug 24, 2022
This was referenced Aug 29, 2022
Closed
Closed
This was referenced Aug 30, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v14 drops Node 12 support which doesn't impact us, other changes also don't require code updates, see: https://github.com/sinonjs/sinon/blob/v14.0.0/CHANGES.md
Changes
sinonthroughout packages to 14.0.0