feat: ignore-compatibility-db #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
reviewed
Aug 1, 2022
| hooks.push(createPackageExtender(fromPairs(compatPackageExtensions))) | ||
| if (!ignoreCompatibilityDb) { | ||
| hooks.push(createPackageExtender(fromPairs(compatPackageExtensions))) | ||
| } |
There was a problem hiding this comment.
It's also worth considering whether these fixups should be applied earlier, since
pnpmfile.cjsis less useful if it is not the final authority about version selections.
(This part could maybe be a separate PR since it doesn't affect our use case with ignoreCompatibilityDb=true. But I do suspect that users would be surprised to learn that the input to pnpmfile.cjs does not reflect some hooks, and the actions of pnpmfile.cjs may get overridden by compatibility db fixups.)
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5132