Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages with default peer dependencies #5210

Merged
merged 3 commits into from Aug 17, 2022
Merged

fix: packages with default peer dependencies #5210

merged 3 commits into from Aug 17, 2022

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Aug 15, 2022

When the same package is both in "peerDependencies" and in "dependencies", treat this dependency as a peer dependency if it may be resolved from the dependencies of parent packages.

@zkochan zkochan requested a review from a team August 15, 2022 21:56
Copy link
Contributor

@d3lm d3lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zkochan zkochan merged commit 071aa18 into main Aug 17, 2022
@zkochan zkochan deleted the default-peer0 branch August 17, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants