Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: time-based resolution mode #5238

Merged
merged 3 commits into from Sep 2, 2022
Merged

feat: time-based resolution mode #5238

merged 3 commits into from Sep 2, 2022

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Aug 19, 2022 •
edited

Related RFC: pnpm/rfcs#2

TODO

  • add tests
  • prefer latest versions
  • add some delta to the publishedBy date
  • remove not needed fields from the full meta before saving it to disk
  • save publishedBy (it should also include the id of the last published package) in the lockfile and don't use forceResolution

@zkochan zkochan mentioned this pull request Aug 20, 2022
Merged
@Jack-Works
Copy link
Member

is it the --before option in npm? https://docs.npmjs.com/cli/v8/using-npm/config#before 🤔

@zkochan
Copy link
Member Author

zkochan commented Aug 20, 2022

I did not know about before.

This works partially as before. Please review my RFC: pnpm/rfcs#2

@zkochan zkochan changed the title feat: time-base resolution mode feat: time-based resolution mode Aug 20, 2022
@zkochan zkochan force-pushed the time-based-resolution-mode branch 6 times, most recently from 9e138b9 to 93b1207 Compare August 30, 2022 22:45
@zkochan zkochan marked this pull request as ready for review August 31, 2022 20:07
@zkochan zkochan requested a review from a team August 31, 2022 20:07
mcmxcdev
mcmxcdev approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@mcmxcdev mcmxcdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really solid, couldn't spot anything!

@zkochan zkochan merged commit 67d8b65 into main Sep 2, 2022
@zkochan zkochan deleted the time-based-resolution-mode branch September 2, 2022 11:54
zkochan added a commit that referenced this pull request Sep 2, 2022
@zkochan
feat: resolve direct deps to lowest version when resolution-mode is t…
2477365 
…ime-based (#5298)

ref #5238
@zkochan zkochan added this to the v7.10 milestone Sep 2, 2022
@Jack-Works
Copy link
Member

if we switch to this new resolution mode for an existing project, does it cause our dependency to be downgraded? 👀

This was referenced Sep 3, 2022
Merged
Merged
@quanru quanru mentioned this pull request Jun 25, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmxcdev mcmxcdev mcmxcdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zkochan @Jack-Works @mcmxcdev