Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node<16 download fail on arm chips on macos #5239

Merged
merged 2 commits into from Aug 20, 2022
Merged

fix: node<16 download fail on arm chips on macos #5239

merged 2 commits into from Aug 20, 2022

Commits on Aug 20, 2022

  1. fix(node.fetcher): node < 16 download fail on apple silicon 

    Add a check for macos apple silicon and required node version < 16.
In such case, download x64 binary.
Because arm build does not exist.
Previous behaviour:
Try to download non existing arm build and fail with 404.

NO breaking change
fixes pnpm#4489
    @ambar-arkin
    ambar-arkin committed Aug 20, 2022
    Copy the full SHA
    596af9a View commit details
    Browse the repository at this point in the history

  2. refactor(node.fetcher): move code to normalizeArch

    @ambar-arkin
    ambar-arkin committed Aug 20, 2022
    Copy the full SHA
    8ec10d6 View commit details
    Browse the repository at this point in the history