feat: add warning if package.json specifies workspaces #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
|
@zkochan please give advice, first contribution and we probably want to add test cases for this + clean it up (maybe provide typings for package.json file, since today the parsed json is any typed) |
|
We already read the package.json file. No need to read it again. Put the check here: https://github.com/pnpm/pnpm/blob/main/packages/cli-utils/src/readProjectManifest.ts |
zkochan
added a commit
that referenced
this pull request
Oct 25, 2022
|
I have created a new PR: #5547 |
zkochan
added a commit
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add a suggestion to use pnpm-workspace.yaml > package.json in cases where a user still has workspaces specified in their package.json file, per #5363 .