Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add dir option support in link <pkg> --global #5473

Merged
merged 4 commits into from Oct 10, 2022
Merged

fix: add dir option support in link <pkg> --global #5473

merged 4 commits into from Oct 10, 2022

Conversation

lvqq
Copy link
Member

@lvqq lvqq commented Oct 9, 2022

Fix:

  1. add dir option support in pnpm link <pkg> --global
  2. remove WARN undefined has no binaries

@lvqq lvqq requested a review from zkochan as a code owner October 9, 2022 16:04
@zkochan
Copy link
Member

zkochan commented Oct 10, 2022

This whole --global and --dir code is a bit confusing currently. In other commands --global is a replacement for --dir. --global is like running --dir=<global-dir>.

We should probably change how packages are linked globally in the next version of pnpm.

@zkochan zkochan merged commit 96b507b into pnpm:main Oct 10, 2022
@zkochan zkochan added this to the v7.13 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lvqq @zkochan