fix: pnpm link --global <pkg> should not change the type of the dependency #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvqq
force-pushed
the
fix-link-global-dependency
branch
from
dc818ed
to
d6471f6
Compare
lvqq
force-pushed
the
fix-link-global-dependency
branch
from
d6471f6
to
6fb896b
Compare
zkochan
reviewed
Oct 18, 2022
zkochan
approved these changes
Oct 19, 2022
packages/types/src/misc.ts
Outdated
| @@ -1,5 +1,7 @@ | |||
| export type DependenciesField = 'optionalDependencies' | 'dependencies' | 'devDependencies' | |||
|
|
|||
| export type DependenciesManifestField = DependenciesField | 'peerDependencies' | |||
There was a problem hiding this comment.
This name doesn't make sense. Maybe rename it to DependenciesAndPeersField
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5478