Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot set property name of which has only a getter #5574

Merged
merged 1 commit into from Nov 2, 2022
Merged

fix: cannot set property name of which has only a getter #5574

merged 1 commit into from Nov 2, 2022
+10 −1

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Nov 2, 2022

close #5572

lvqq
lvqq reviewed Nov 2, 2022
View reviewed changes
packages/pnpm/src/err.ts
error.name = 'pnpm'
} catch {
// Sometimes the name property is read-only
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change can also be merged to v6 branch since there has a similar issue: #4270

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, wow

@zkochan zkochan merged commit 14974d8 into main Nov 2, 2022
@zkochan zkochan deleted the fix/5572 branch November 2, 2022 08:36
@zkochan zkochan mentioned this pull request Nov 2, 2022
Closed
zkochan added a commit that referenced this pull request Nov 2, 2022
@zkochan
fix: cannot set property name of which has only a getter (#5574)
f61de1d 
close #5572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvqq lvqq lvqq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot set property name of which has only a getter
2 participants
@zkochan @lvqq