fix: improve license file reading logic #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file index is of the appropriate type so we can leverage the contents of `PackageFileInfo`-type we try to lookup the file mode to and pass it to the `readLicenseFileFromCafs`-function so it can be correctly passed to the underlying `getFilePathByModeInCafs`-function responsible for fetching the file from the PNPM store
|
Potential fix for #5737 . Got to find a way to reproduce the issue |
|
It should be covered with a test. |
added 2 commits
December 8, 2022 11:58
Added a test to verify that the LICENSE files of the `svgicons2svgfont@5.0.2`-package and similar packages can be read without errors
|
Not sure what's going on with the Windows tests. Wouldn't expect the fail in this manner (type definitions missing) |
|
The CI issue is not related to your changes. |
zkochan
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file index is of the appropriate type so we can leverage the contents of
PackageFileInfo-type we try to lookup the file mode to and pass it to thereadLicenseFileFromCafs-function so it can be correctly passed to the underlyinggetFilePathByModeInCafs-function responsible for fetching the file from the PNPM store