Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not replace workspace:* when update #5764

Merged

Conversation

await-ovo
Copy link
Member

@await-ovo await-ovo commented Dec 7, 2022

close #5317
close #5303
close #5312
close #5726

@zkochan
Copy link
Member

zkochan commented Dec 8, 2022

The same should apply for packages referenced via workspace:~ and workspace:^

@await-ovo
Copy link
Member Author

The same should apply for packages referenced via workspace:~ and workspace:^

Thanks for your advice, the latest commit have this fix ~

@zkochan zkochan merged commit 49f6c91 into pnpm:main Dec 9, 2022
@zkochan zkochan modified the milestones: v7.19, v7.18 Dec 28, 2022
@folknor
Copy link

folknor commented Jan 25, 2023

Hello @await-ovo !
This PR seems to have changed the behavior of pnpm in an possibly unintended way?
Please see the discussion in #5720 (comment) and towards the end of the ticket.

The behavior is still there with the very latest release as of today.

As you can see in that thread, HomeyKing linked this as the offending change: https://github.com/pnpm/pnpm/pull/5764/files#diff-d2d9ebb33dc9a2437d69f3c4c77d5e194a34b29dc80bce3a23a3aca0a45c4866L165

Please take a look :-) Thank you!

@await-ovo
Copy link
Member Author

@folknor Thank you for reporting this issue, I'll check it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants