Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw an error while missing script start or server.js #5782

Merged
merged 2 commits into from Dec 12, 2022

Conversation

lvqq
Copy link
Member

@lvqq lvqq commented Dec 12, 2022

Missing script start or server.js should print an error but got with:

> node server.js

internal/modules/cjs/loader.js:905
  throw err;
  ^

Error: Cannot find module '/xxx/server.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

@lvqq lvqq requested a review from zkochan as a code owner December 12, 2022 08:23
@zkochan zkochan enabled auto-merge (squash) December 12, 2022 10:15
@zkochan zkochan merged commit f5c377a into main Dec 12, 2022
@zkochan zkochan deleted the fix-pnpm-start branch December 12, 2022 10:47
@weyert
Copy link
Contributor

weyert commented Dec 12, 2022

Is this related and the server.js file reference related to store/plugin-commands-server/src/server.ts?

@zkochan
Copy link
Member

zkochan commented Dec 12, 2022

not related

@zkochan zkochan modified the milestones: v7.19, v7.18 Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants