Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the config commands #5829

Merged
merged 18 commits into from Dec 24, 2022
Merged

feat: implement the config commands #5829

merged 18 commits into from Dec 24, 2022

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Dec 23, 2022

close #5621

This change may be considered breaking but if we don't do this change then the config commands break anyway when npm CLI gets updated. So I think it should be OK.

@zkochan zkochan marked this pull request as ready for review December 24, 2022 02:10
@zkochan zkochan requested a review from a team December 24, 2022 02:11
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkochan zkochan merged commit 841f52e into main Dec 24, 2022
@zkochan zkochan deleted the config-set branch December 24, 2022 15:08
@zkochan zkochan added this to the v7.20 milestone Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set store-dir in NPM v9
2 participants