fix: replace version number for namespaced workspace packages #6052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch 'workspace:@foo/bar@*' is replaced by 'npm:@foo/bar@*' on publish, i.e. the * is not replaced by the actual version number from @foo/bar's package.json.
|
💖 Thanks for opening this pull request! 💖 |
|
add a test, please and change sets |
zkochan
approved these changes
Feb 8, 2023
12 tasks
|
Congrats on merging your first pull request! 🎉🎉🎉 |
zkochan
added a commit
that referenced
this pull request
Feb 8, 2023
Without this patch 'workspace:@foo/bar@*' is replaced by 'npm:@foo/bar@*' on publish, i.e. the * is not replaced by the actual version number from @foo/bar's package.json. Co-authored-by: Zoltan Kochan <z@kochan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch
workspace:@foo/bar@*is replaced bynpm:@foo/bar@*on publish, i.e. the*is not replaced by the actual version number from@foo/bar'spackage.json.