feat: support --patches-dir on patch-commit command
#6215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
taozhou-glean
force-pushed
the
tao-patches-dir
branch
from
7f47b6d
to
e84ca50
Compare
taozhou-glean
changed the title
--patches-dir to patch-commit command--patches-dir on patch-commit command
taozhou-glean
commented
Mar 14, 2023
| const userDir = params[0] | ||
| const lockfileDir = opts.lockfileDir ?? opts.dir ?? process.cwd() | ||
| const patchesDir = path.join(lockfileDir, 'patches') | ||
| const patchesDirName = opts.patchesDir ?? 'patches' | ||
| const patchesDir = path.join(lockfileDir, patchesDirName) |
There was a problem hiding this comment.
i thought about supporting arbitrary path for patches-dir, but realize it's likely not a common case and will require more changes, so decide to always assume path under lockfileDir.
zkochan
reviewed
Mar 15, 2023
zkochan
force-pushed
the
tao-patches-dir
branch
from
4f56b34
to
a573d71
Compare
zkochan
approved these changes
Mar 16, 2023
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #6202