Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: installing local dep from directory that starts with @ #6350

Merged
merged 2 commits into from Apr 3, 2023
Merged

fix: installing local dep from directory that starts with @ #6350

merged 2 commits into from Apr 3, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Apr 3, 2023

close #6332

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 3, 2023
View reviewed changes
packages/dependency-path/src/index.ts Outdated
export function tryGetPackageId (registries: Registries, relDepPath: string) {
if (relDepPath[0] !== '/') {
return null
}
const sepIndex = relDepPath.indexOf('(')
if (sepIndex !== -1) {
return resolve(registries, relDepPath.slice(0, sepIndex))
if (sepIndex !== -1 && relDepPath.search(PEERS_SUFFIX_REGEX) !== -1) {

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
packages/dependency-path/src/index.ts Outdated
if (sepIndex !== -1) {
return resolve(registries, relDepPath.slice(0, sepIndex))
if (sepIndex !== -1 && relDepPath.search(PEERS_SUFFIX_REGEX) !== -1) {
return resolve(registries, relDepPath.replace(PEERS_SUFFIX_REGEX, ''))

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '(()'.
This
regular expression
that depends on
library input
may run slow on strings starting with '(' and with many repetitions of '('.
@zkochan zkochan merged commit 94f94ee into main Apr 3, 2023
14 checks passed
@zkochan zkochan deleted the fix/6332 branch April 3, 2023 23:36
zkochan added a commit that referenced this pull request Apr 3, 2023
@zkochan
fix: installing local dep from directory that starts with @ (#6350)
49ab18c 
close #6332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY when using local package as dependency
1 participant
@zkochan